-
-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Bukkit#getName() for server name #418
Conversation
This would fix the existing issue on 1.21. LGTM |
Unfortunately the server type string is used to determine which mappings to use -- https://github.com/lucko/spark-mappings/blob/master/dist/mappings.json#L3 Instead could we incorporate the server brand into the version string? |
|
fbb2b59
to
7953663
Compare
7953663
to
7320cf9
Compare
Decided to just add a Thank you for the PR! |
Paper (1.20.6+) Before:
Paper After:
Spigot:
Maybe need to check if the version contains Spigot then use 'Spigot' as the server name? But imho Spigot..