Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Bukkit#getName() for server name #418

Closed
wants to merge 7 commits into from

Conversation

powercasgamer
Copy link
Contributor

@powercasgamer powercasgamer commented Jun 22, 2024

Paper (1.20.6+) Before: firefox_W3qNuFf7p9

Paper After: firefox_g9RutfYRN8

Spigot: firefox_UZIQFJuCmO

Maybe need to check if the version contains Spigot then use 'Spigot' as the server name? But imho Spigot..

@EterNityCH
Copy link

This would fix the existing issue on 1.21. LGTM

@lucko
Copy link
Owner

lucko commented Jul 4, 2024

Unfortunately the server type string is used to determine which mappings to use -- https://github.com/lucko/spark-mappings/blob/master/dist/mappings.json#L3

Instead could we incorporate the server brand into the version string?

@powercasgamer
Copy link
Contributor Author

powercasgamer commented Jul 7, 2024

Unfortunately the server type string is used to determine which mappings to use -- lucko/spark-mappings@master/dist/mappings.json#L3

Instead could we incorporate the server brand into the version string?

Something like this?
Paper: firefox_5UoVDQtlul

Spigot: firefox_VOL2Rxroeb

Purpur: firefox_Zj6ROE5mgr

I'm not actually sure how it'll look on older versions. Perhaps a version check? Or not bother making it look good on <1.20.5?
Paper 1.19.4: firefox_BDh75ytoRe

For Spigot we could also check if the string contains "Spigot" and then just not add it or something.

@lucko
Copy link
Owner

lucko commented Jul 7, 2024

Decided to just add a brand field separate from name so we can show it nicely :)

lucko/spark-viewer@568817f

Thank you for the PR!

@lucko lucko closed this Jul 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants