Close #10 #7: add pkg-config install for brew #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…brew The line in the install script output reported by two of the users (and experienced by me): "make: /usr/local/bin/pkg-config: Command not found" Caused me to make a link from my pkg-config I already had to /usr/local/bin/pkg-config. This didn't help much as that copy of pkg-config had no idea where all the .pc library files were. As I started manually adding the paths to the .pc files needed to pkg-config's search path, I eventually realized that there had to be a much better way. On a hunch, I installed a new copy of pkg-config from brew and successfully compiled visualSFM. Because the pkg-config installed by brew needs to be run, I suspect that luckybulldozer#12 might just be using the wrong pkg-config and possibly fixed by this change as well. Close luckybulldozer#10 luckybulldozer#7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The line in the install script output reported by two of the users (and experienced by me):
"make: /usr/local/bin/pkg-config: Command not found"
Caused me to make a link from my pkg-config I already had to /usr/local/bin/pkg-config. This didn't help much as that copy of pkg-config had no idea where all the .pc library files were. As I started manually adding the paths to the .pc files needed to pkg-config's search path, I eventually realized that there had to be a much better way. On a hunch, I installed a new copy of pkg-config from brew and successfully compiled visualSFM.
Because the pkg-config installed by brew needs to be run, I suspect that #12 might just be using the wrong pkg-config and possibly fixed by this change as well.
Edit: I have not used github before, apologies in advance.
Close #10 #7