Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding new path_without_query_params method #1572

Merged
merged 1 commit into from
Sep 2, 2021
Merged

Adding new path_without_query_params method #1572

merged 1 commit into from
Sep 2, 2021

Conversation

jwoertink
Copy link
Member

Purpose

Fixes #1571

Description

We already have a url_without_query_params method. This adds in the path version to be complimentary.

Checklist

  • - An issue already exists detailing the issue/or feature request that this PR fixes
  • - All specs are formatted with crystal tool format spec src
  • - Inline documentation has been added and/or updated
  • - Lucky builds on docker with ./script/setup
  • - All builds and specs pass on docker with ./script/test

@jwoertink jwoertink merged commit 5e283d2 into master Sep 2, 2021
@jwoertink jwoertink deleted the issues/1571 branch September 2, 2021 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewmcgarvey matthewmcgarvey matthewmcgarvey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add path_without_query_params method
2 participants
@jwoertink @matthewmcgarvey