Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ExceptionPage and fix the error title. #1921

Merged
merged 1 commit into from
Oct 13, 2024
Merged

Update ExceptionPage and fix the error title. #1921

merged 1 commit into from
Oct 13, 2024

Conversation

jwoertink
Copy link
Member

Purpose

Fixes #1920

Description

The ExceptionPage error messages used to say "Error 404", but they were changed to "Not Found". This updates the title to include both so now it'll say "Error 404 Not Found"

Checklist

  • - An issue already exists detailing the issue/or feature request that this PR fixes
  • - All specs are formatted with crystal tool format spec src
  • - Inline documentation has been added and/or updated
  • - Lucky builds on docker with ./script/setup
  • - All builds and specs pass on docker with ./script/test

@jwoertink jwoertink merged commit 8884d3b into main Oct 13, 2024
5 checks passed
@jwoertink jwoertink deleted the issues/1920 branch October 13, 2024 22:18
@jwoertink jwoertink added the hacktoberfest-accepted PRs accepted for Hacktoberfest label Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted PRs accepted for Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exception page failures in CI
1 participant