Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ✨ loose icons #56

Merged
merged 2 commits into from
Apr 7, 2024
Merged

feat: ✨ loose icons #56

merged 2 commits into from
Apr 7, 2024

Conversation

lucas-labs
Copy link
Member

@lucas-labs lucas-labs commented Apr 7, 2024

allow icons that are not associated to any folder/file but that can be configured later by the user manually.

export type LucodearFileIcon = RequireAtLeastOne<
  BasicFileIcon & {
    looseFileIcon?: true;
    theme?: string;
  },
  'fileExtensions' | 'fileNames' | 'looseFileIcon'
>;

export type LucodearFolderIcon = RequireAtLeastOne<
  Omit<FolderIcon, 'folderNames'> & {
    theme?: string;
    looseFolderIcon?: true;
    folderNames?: string[];
  },
  'looseFolderIcon' | 'folderNames'
>;

Adds looseFileIcon and looseFolderIcon to the LucodearFileIcon and LucodearFolderIcons types, respectively.

Setting this fields to true allows defining an icon that is not "tied" to any file extension, name, folder name, etc, but they will be still present in the final extension definition json, so that the user can use them via configuration setting.

Copy link

github-actions bot commented Apr 7, 2024

Preview

Thank you for creating a pull request. This preview shows you how your changes will look on the different themes:

Generated Preview

You can find more information how to contribute in the contribution guidelines.

Copy link

github-actions bot commented Apr 7, 2024

Preview

Thank you for creating a pull request. This preview shows you how your changes will look on the different themes:

Generated Preview

You can find more information how to contribute in the contribution guidelines.

@lucas-labs lucas-labs merged commit 4b1738b into main Apr 7, 2024
3 checks passed
@lucas-labs lucas-labs deleted the feat/loose-icons branch April 7, 2024 04:29
Copy link

github-actions bot commented Apr 7, 2024

Merge Successful

Thanks for your contribution! 🎉

The changes will be part of the upcoming update on the marketplace.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant