Merge with origin #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: ✨ clone and recolorize icons * feat: ✨ integrate icon cloning with the the extension * chore: 🧹 update vscode-test dependency vscode-test was renamed to @vscode/test-electron and the former package was unable to run tests on windows. this commit removes vscode-test and updates it to the last version of @vscode/test-electron * test: 🧪 fix failing tests * refactor: 🔨 improve in-code docs & comments * feat: ✨ config to create light variants of the icon * feat: ✨ improve recolorization improves recolorization logic, keeping originally darker colors dark and lighter colors light even after recolor * feat: ✨ edge cases: support ignoring recolorizing paths adds support for a custom svg attribute `mit-no-recolor` that, when set to true, will keep the original color of the svg node on which is applied * feat: ✨ do not recolor some paths in some edge-case icons * feat: ✨ jsconfig edge-case * refactor: 🔨 simplify cloning process * feat: ✨ allow creating clones at build time support for creating clones by configuring them in the fileIcons.ts and folderIcons.ts files so that the icons are created at build time allowing contributors to create clones that are shipped with the extension * test: 🧪 test clone configuration generation * chore: 🧹 fix file names to camelCase to match project style * test: 🧪 test clone data config generation * test: 🧪 color manipulation tests * test: 🧪 test svg cloning and recolor * test: 🧪 json config generation from user options * docs: 📝 update contributing guide and readme * feat: ✨ documentation for `mit-no-recolor` attribute * fix: 🚑 icon availability check failing on clone icons * fix: 🚑 broken links when generating icons preview png * fix: 🚑 icon usage check failing for clone icons * docs: 📝 CONTRIBUTING.md - add missing section to the TOC * fix: 🚑 filter out cloned icons from README preview pngs --------- Co-authored-by: Philipp Kief <[email protected]>
* Modernize svgo config * feat: update release yml --------- Co-authored-by: Philipp Kief <[email protected]>
PreviewThank you for creating a pull request. This preview shows you how your changes will look on the different themes: You can find more information how to contribute in the contribution guidelines. |
Merge SuccessfulThanks for your contribution! 🎉 The changes will be part of the upcoming update on the marketplace. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.