Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra #s from Makefile #1096

Closed
wants to merge 3 commits into from
Closed

Remove extra #s from Makefile #1096

wants to merge 3 commits into from

Conversation

michplunkett
Copy link
Collaborator

Description of Changes

Remove unnecessary #s from the Makefile.

Tests and Linting

  • This branch is up-to-date with the develop branch.
  • pytest passes on my local development environment.
  • pre-commit passes on my local development environment.
  • Manually tested that make commands still work
(env) michaelp@MacBook-Air-18 OpenOversight % make lint
pre-commit run --all-files
trim trailing whitespace.................................................Passed
check docstring is first.................................................Passed
check that executables have shebangs.....................................Passed
check json...............................................................Passed
check for case conflicts.................................................Passed
check toml...........................................(no files to check)Skipped
check for merge conflicts................................................Passed
check xml................................................................Passed
check yaml...............................................................Passed
fix end of files.........................................................Passed
check for broken symlinks............................(no files to check)Skipped
mixed line ending........................................................Passed
fix python encoding pragma...............................................Passed
pretty format json.......................................................Passed
fix requirements.txt.....................................................Passed
check blanket noqa.......................................................Passed
check for not-real mock methods..........................................Passed
check for eval().........................................................Passed
use logger.warning(......................................................Passed
Run isort to sort imports................................................Passed
Run pydocstyle...........................................................Passed
Do not use shebangs in non-executable files..............................Passed
flynt....................................................................Passed
flake8...................................................................Passed
black....................................................................Passed
mypy.....................................................................Passed
djLint formatting........................................................Passed
djLint linting...........................................................Passed
(env) michaelp@MacBook-Air-18 OpenOversight % 

@michplunkett
Copy link
Collaborator Author

Made these changes in this PR, #1082, so I'm gonna close this bb.

@michplunkett michplunkett deleted the correct_makefile branch April 30, 2024 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant