Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Font Awesome from 6.5.1 to 6.5.2. #901

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

simonhollingshead
Copy link
Contributor

@simonhollingshead simonhollingshead commented Apr 6, 2024

Prerequisites

Put an x into the box(es) that apply:

  • This pull request fixes a bug.
  • This pull request adds a feature.
  • This pull request introduces breaking change.

Description

This PR updates the version of Font Awesome used within the project from 6.5.1 Free to 6.5.2 Free. This adds additional characters.

The files are directly copied out of the published archive file with no alterations.

Please note that the CSS regeneration also seems to have pulled in the mastodon SCSS originally added in #885 - it looks like nobody regenerated the CSS during that PR. For what it's worth, a while back I did make a comment #864 about the fact that I have fully automated the CSS regeneration for my own branch using a Github action. You may want to consider it too (by which I mean 'tell me if you want it contributed back').

Issues Resolved

None

Checklist

Put an x into the box(es) that apply:

General

  • Describe what changes are being made
  • Explain why and how the changes were necessary and implemented respectively
  • Reference issue with #<ISSUE_NO> if applicable

Resources

  • If you have changed any SCSS code, run make release to regenerate all CSS files

Contributors

  • Add yourself to CONTRIBUTORS.md if you aren't on it already

Copy link
Owner

@luizdepra luizdepra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, ty.

@luizdepra luizdepra merged commit 33fd0ab into luizdepra:main Apr 8, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants