Fixed handling of build request user in build overview (#33)

luka-grabarevic · Aug 3, 2018 · 2ae782f · 2ae782f
1 parent a143566
commit 2ae782f
Show file tree

Hide file tree

Showing 5 changed files with 20 additions and 7 deletions.
diff --git a/BuildsAppReborn.Access/TFS/Models/TfsBuild.cs b/BuildsAppReborn.Access/TFS/Models/TfsBuild.cs
@@ -33,14 +33,22 @@ public IUser DisplayUser
         {
             get
             {
-                if (SourceVersion != null)
+                // if not requested by service user, it was by user. So show user.
+                if (Requester != null && !Requester.IsServiceUser)
                 {
-                    if (SourceVersion.Pusher.Id != TfsConsts.MicrosoftTeamFoundationSystemId)
+                    return Requester;
+                }
+
+                // tries to determine the pusher of the commit, and show him if not service user
+                if (SourceVersion?.Pusher != null)
+                {
+                    if (!SourceVersion.Pusher.IsServiceUser)
                     {
                         return SourceVersion.Pusher;
                     }
                 }
 
+                // fallback value
                 return Requester;
             }
         }
@@ -99,7 +107,7 @@ public BuildReason Reason
             }
         }
 
-        [JsonProperty("requestedFor")]
+        [JsonProperty("requestedBy")]
         public abstract IUser Requester { get; protected set; }
 
         [JsonIgnore]

diff --git a/BuildsAppReborn.Access/TFS/Models/TfsUser.cs b/BuildsAppReborn.Access/TFS/Models/TfsUser.cs
@@ -34,6 +34,9 @@ public Byte[] ImageData
         [JsonProperty("imageUrl")]
         public String ImageUrl { get; private set; }
 
+        [JsonIgnore]
+        public Boolean IsServiceUser => Id == TfsConsts.MicrosoftTeamFoundationSystemId;
+
         public override String Name
         {
             get { return base.Name ?? DisplayName; }

diff --git a/BuildsAppReborn.Access/TFS/TfsBuildProviderBase.cs b/BuildsAppReborn.Access/TFS/TfsBuildProviderBase.cs
@@ -188,7 +188,7 @@ private static async Task<TSourceVersion> GetTfsGitSourceVersionAsync(BuildMonit
             if (build.Reason == BuildReason.PullRequest || 
                 build.Reason == BuildReason.Validation)
             {
-                if (sourceVersion != null && sourceVersion.Parents.Length > 1 && sourceVersion.Pusher.Id == TfsConsts.MicrosoftTeamFoundationSystemId)
+                if (sourceVersion?.Parents != null && sourceVersion.Parents.Length > 1 && sourceVersion.Pusher != null && sourceVersion.Pusher.IsServiceUser)
                 {
                     var innerRequestUrl = $"{projectUrl}/_apis/git/repositories/{build.Repository.Id}/commits/{sourceVersion.Parents.Last()}?api-version=1.0";
 

diff --git a/BuildsAppReborn.Contracts.UI/BuildItem.cs b/BuildsAppReborn.Contracts.UI/BuildItem.cs
@@ -79,7 +79,7 @@ public String Comment
             {
                 if (Build?.SourceVersion?.Comment != null)
                 {
-                    return ManualRequested ? $"{Build.DisplayUser.DisplayName}: {Build.SourceVersion.Comment}" : Build.SourceVersion.Comment;
+                    return ManuallyRequested ? $"{Build.SourceVersion.Pusher.DisplayName}: {Build.SourceVersion.Comment}" : Build.SourceVersion.Comment;
                 }
 
                 return "-";
@@ -103,7 +103,7 @@ public String Description
 
         public Byte[] DisplayUserImage => Build?.DisplayUser?.ImageData;
 
-        public String DisplayUserText => ManualRequested ? $"Requested by: {Build.Requester.DisplayName}" : Build.DisplayUser.DisplayName;
+        public String DisplayUserText => ManuallyRequested ? $"Requested by: {Build.Requester.DisplayName}" : Build.DisplayUser.DisplayName;
 
         [SuppressMessage("ReSharper", "ExplicitCallerInfoArgument")]
         public void Refresh()
@@ -116,7 +116,7 @@ public void Refresh()
             OnPropertyChanged(nameof(CurrentTestRun));
         }
 
-        private Boolean ManualRequested => Build.Reason == BuildReason.Manual;
+        private Boolean ManuallyRequested => !Build.Requester.IsServiceUser;
 
         private readonly BuildViewStyle viewStyle;
     }

diff --git a/BuildsAppReborn.Contracts/Models/IUser.cs b/BuildsAppReborn.Contracts/Models/IUser.cs
@@ -13,6 +13,8 @@ public interface IUser : IObjectItem
 
         String ImageUrl { get; }
 
+        Boolean IsServiceUser { get; }
+
         String UniqueName { get; }
     }
 }