fixed missing disposal on update check

luka-grabarevic · Feb 27, 2017 · c36b772 · c36b772
1 parent 7dbddb1
commit c36b772
Showing 1 changed file with 20 additions and 18 deletions.
diff --git a/BuildsAppReborn.Client/UpdateChecker.cs b/BuildsAppReborn.Client/UpdateChecker.cs
@@ -76,26 +76,28 @@ private async Task UpdateCheckInternal()
             try
             {
                 var repo = Settings.Default.UpdateCheckUrl;
-                var updateMgrTask = UpdateManager.GitHubUpdateManager(repo, null, null, null, GeneralSettings.IncludePreReleases);
-
-                var updateManager = await updateMgrTask;
-
-                if (!GeneralSettings.AutoInstall)
-                {
-                    var updateInfo = await updateManager.CheckForUpdate();
-                    if (GeneralSettings.NotifyOnNewUpdate)
-                    {
-                        // ToDo: show if new update available
-                    }
-                    // ToDo: implement update when user accepts
-                }
-                else
+                using (var updateMgrTask = UpdateManager.GitHubUpdateManager(repo, null, null, null, GeneralSettings.IncludePreReleases))
                 {
-                    var result = await updateManager.UpdateApp();
-                    if (GeneralSettings.NotifyOnNewUpdate)
+                    using (var updateManager = await updateMgrTask)
                     {
-                        if (result == null) this.notificationProvider.ShowMessage($"{this.version.ProductName} Update Check finished", "Currently no new updates");
-                        else this.notificationProvider.ShowMessage($"{this.version.ProductName} New update found!", "Update will be installed automatically on next start.");
+                        if (!GeneralSettings.AutoInstall)
+                        {
+                            var updateInfo = await updateManager.CheckForUpdate();
+                            if (GeneralSettings.NotifyOnNewUpdate)
+                            {
+                                // ToDo: show if new update available
+                            }
+                            // ToDo: implement update when user accepts
+                        }
+                        else
+                        {
+                            var result = await updateManager.UpdateApp();
+                            if (GeneralSettings.NotifyOnNewUpdate)
+                            {
+                                if (result == null) this.notificationProvider.ShowMessage($"{this.version.ProductName} Update Check finished", "Currently no new updates");
+                                else this.notificationProvider.ShowMessage($"{this.version.ProductName} New update found!", "Update will be installed automatically on next start.");
+                            }
+                        }
                     }
                 }
             }