Fix broken dynamic import #159
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -14,7 +15,6 @@ export default async (args) => { | |||
|
|
|||
| const results = args.results | |||
| if (!fs.existsSync(results)) { | |||
| const { showHelp } = import('./src/cli/args.js') | |||
| showHelp() | |||
There was a problem hiding this comment.
With this fix, I see the error below when I run the following command (the test_logs directory exists, but foo.xml does not)
xunit-viewer -r test_logs/foo.xml
TypeError: Cannot write private member to an object whose class did not declare it
at O (/Users/williamwallace/.config/yarn/global/node_modules/yargs/build/index.cjs:1:3385)
at showHelp (/Users/williamwallace/.config/yarn/global/node_modules/yargs/build/index.cjs:1:42722)
at default (file:///Users/williamwallace/.config/yarn/global/node_modules/xunit-viewer/xunit-viewer.js:18:5)
at file:///Users/williamwallace/.config/yarn/global/node_modules/xunit-viewer/bin/xunit-viewer.js:6:1
at ModuleJob.run (node:internal/modules/esm/module_job:222:25)
at async ModuleLoader.import (node:internal/modules/esm/loader:323:24)
at async loadESM (node:internal/process/esm_loader:28:7)
at async handleMainPromise (node:internal/modules/run_main:120:12)
|
@steve-taylor could you elaborate on why it is broken? |
The cause is explained here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dynamic import should have used
awaitso it would destructure the imported module rather than thePromisereturned byimport('./src/cli/args.js').Rather than add
await, I converted it to a static import because the dynamic import seemed unnecessary.