Ensure S3 bucket options are properly propagated (#125)

* fix: remove circular ref in S3 bucket construct This ensures that S3 bucket options are properly propagated! * chore: add changeset
lukeshay · Mar 17, 2024 · 48af5d1 · 48af5d1
1 parent 5a667be
commit 48af5d1
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/.changeset/blue-carpets-deny.md b/.changeset/blue-carpets-deny.md
@@ -0,0 +1,5 @@
+---
+"@astro-aws/constructs": patch
+---
+
+Fixed circular reference in S3 bucket construct which prevented configuration of the S3 part of the infrastructure.
diff --git a/packages/constructs/src/constructs/astro-aws-s3-bucket.ts b/packages/constructs/src/constructs/astro-aws-s3-bucket.ts
@@ -44,7 +44,7 @@ class AstroAWSS3Bucket extends AstroAWSBaseConstruct<
 			blockPublicAccess: BlockPublicAccess.BLOCK_ALL,
 			encryption: BucketEncryption.S3_MANAGED,
 			enforceSSL: true,
-			...this.cdk.s3Bucket,
+			...props.cdk?.s3Bucket,
 		})
 
 		this.#originAccessIdentity = new OriginAccessIdentity(this, "S3BucketOAI", {