Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for 404 page and response streaming #109

Merged
merged 8 commits into from
Nov 17, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixed tests
  • Loading branch information
lukeshay committed Nov 17, 2023
commit 170cbaa09949cf858a70cd3b28546ae629af96ff
1 change: 1 addition & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ jobs:
matrix:
node_version:
- 18
- 20
cmd:
- build
- test
Expand Down
13 changes: 11 additions & 2 deletions packages/adapter/src/__tests__/index.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,9 @@ describe("index.ts", () => {
describe("getAdapter", () => {
const args: Args = {
binaryMediaTypes: [faker.string.sample()],
esBuildOptions: {},
locals: {},
mode: "ssr",
}

describe("when there are arguments", () => {
Expand All @@ -36,10 +39,12 @@ describe("index.ts", () => {
args: {
...args,
esBuildOptions: {},
locals: {},
mode: "ssr",
},
exports: ["handler"],
name: ADAPTER_NAME,
serverEntrypoint: `${ADAPTER_NAME}/lambda/index.js`,
serverEntrypoint: `${ADAPTER_NAME}/lambda/handlers/ssr.js`,
supportedAstroFeatures: {
assets: {
isSharpCompatible: false,
Expand All @@ -66,10 +71,12 @@ describe("index.ts", () => {
args: {
binaryMediaTypes: [],
esBuildOptions: {},
locals: {},
mode: "ssr",
},
exports: ["handler"],
name: ADAPTER_NAME,
serverEntrypoint: `${ADAPTER_NAME}/lambda/index.js`,
serverEntrypoint: `${ADAPTER_NAME}/lambda/handlers/ssr.js`,
supportedAstroFeatures: {
assets: {
isSharpCompatible: false,
Expand Down Expand Up @@ -210,6 +217,8 @@ describe("index.ts", () => {
{
...args,
esBuildOptions: {},
locals: {},
mode: "ssr",
},
)
})
Expand Down