New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fhiclcpp to fhiclcppsimple + some new features #3

Open

jedori0228 wants to merge 7 commits into luketpickering:master from jedori0228:feature/jskim_fhiclcpp_to_fhiclcppsimple

jedori0228 commented Jul 19, 2023

Changing namespace from fhicl to fhiclsimple
0d722b2:
- make_ParameterSet_from_string is added; This is used when converting fhicl to fhiclsimple:

fhiclsimple::ParameterSet nusyst::FhiclToFhiclSimple(const fhicl::ParameterSet& f) {
  return fhiclsimple::make_ParameterSet_from_string( f.to_indented_string() );
}

51e4763:
- I found when fhiclsimple::ParameterSet::to_indented_string is used, string Atoms are converted without quotation marks. e.g., When a ParameterSet with prettyName: "AhtBY" is converted into string, it becomes prettyName: AhtBY

jedori0228 added 7 commits

June 16, 2023 11:03


          Chaning fhiclcpp to fhiclcppsimple

487fb57


          namespace updated as well

55f058e


          Removing extra ;

77e1db9


          Removing extra semi-colons for mrb compiler

684f6e9


          md5 update: use pragma once; add namespace fhiclsimple

1c5dd0e


          make_ParameterSet from string

0d722b2


          hold quotation marks to string atoms

51e4763

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet