Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Make Domain command #51

Closed

Conversation

pelmered
Copy link
Contributor

@pelmered pelmered commented Mar 27, 2024

Works: Creates the configured directory structure for the domain

TODO:

  • Decide how you should specify files that should be generated in the config file
  • Create the files when running the command. This should use the same logic as the make commands. Would you want something more than a service provider by default?
  • Add Documentation in readme and comment in config file

What are your thoughts @JasperTey ?
What do you think about the config format?
How should file generation be added?

@JasperTey
Copy link
Member

Initial high level thoughts: we should be as minimal as possible, similar to:

https://laravel.com/docs/11.x/structure:

By default, the app directory contains the Http, Models, and Providers directories. However, over time, a variety of other directories will be generated inside the app directory as you use the make Artisan commands to generate classes. For example, the app/Console directory will not exist until you execute the make:command Artisan command to generate a command class.

That being said, what is the benefit of this command for the average developer vs. generating domain objects as they go?

@pelmered
Copy link
Contributor Author

Yes, you have a good point. I agree with that. I could just make a new provider with ddd:provider and then set the domain to the name of the new domain I want to create. The would be cleaner.

@pelmered pelmered closed this Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants