Resolve get class string instead of an object. #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix resolve a crash with phpstan or ide-helper
|
Thanks for the PR! I am looking at this today; need to sort out the broken tests before merging. Currently cloning the PR locally and looking into it. |
|
@PhilippeThouvenot - Looks like there some issues with the test suite, unrelated to this change. I need to investigate separately. In the meantime, I will merge this PR into the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve get class string instead of an object.
This fix resolve a crash with phpstan or ide-helper
Exemple :
Internal error: class_exists(): Argument #1 ($class) must be of type string, App\Domain\Project\Database\Factories\TaskFactory given while analysing file
/root/digit/app/Domain/Project/Seeders/TaskSeeder.php