-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for workspaces and external modules in the same repo #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjuulh
force-pushed
the
feat/with-local-directory
branch
2 times, most recently
from
December 5, 2023 13:11
9920762
to
1ef3449
Compare
Signed-off-by: Kasper J. Hermansen <[email protected]>
Signed-off-by: Kasper J. Hermansen <[email protected]>
Signed-off-by: Kasper J. Hermansen <[email protected]>
Signed-off-by: Kasper J. Hermansen <[email protected]>
Signed-off-by: Kasper J. Hermansen <[email protected]>
Signed-off-by: Kasper J. Hermansen <[email protected]>
Signed-off-by: Kasper J. Hermansen <[email protected]>
kjuulh
force-pushed
the
feat/with-local-directory
branch
from
December 5, 2023 13:11
1ef3449
to
c662fce
Compare
Signed-off-by: Kasper J. Hermansen <[email protected]>
Signed-off-by: Kasper J. Hermansen <[email protected]>
Signed-off-by: Kasper J. Hermansen <[email protected]>
Signed-off-by: Kasper J. Hermansen <[email protected]>
Signed-off-by: Kasper J. Hermansen <[email protected]>
Signed-off-by: Kasper J. Hermansen <[email protected]>
Signed-off-by: Kasper J. Hermansen <[email protected]>
Signed-off-by: Kasper J. Hermansen <[email protected]>
Signed-off-by: Kasper J. Hermansen <[email protected]>
mahlunar
reviewed
Dec 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small typo. Looks great!
Signed-off-by: Kasper J. Hermansen <[email protected]>
mahlunar
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr adds a few things:
This is because you may want to use the local packages in the repository in case your actions need to depend on your service or library code.
If workspaces exist, we depend on that solely, as that should tell us where all the subpackages are located
Else if a root module exist we add that. As such both are optional.
It should also work under least surprises, that is if it works in ./actions folder, it should work when the final binaries are compiled
Fixes: AURA-1465, AURA-1466