-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add shuttle extensions cli commands #220
Open
kjuulh
wants to merge
4
commits into
feat/shuttle-extensions
Choose a base branch
from
feat/with-extensions-implmentation
base: feat/shuttle-extensions
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: add shuttle extensions cli commands #220
kjuulh
wants to merge
4
commits into
feat/shuttle-extensions
from
feat/with-extensions-implmentation
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kasper J. Hermansen <[email protected]>
Signed-off-by: Kasper J. Hermansen <[email protected]>
kjuulh
force-pushed
the
feat/shuttle-extensions
branch
from
January 26, 2024 09:17
ce7fa93
to
4822d72
Compare
kjuulh
force-pushed
the
feat/with-extensions-implmentation
branch
from
January 26, 2024 09:17
353eec9
to
c75a15a
Compare
@lunarway/squad-aura I really like to get this merged before hackathon. I am opening up the PRs now (stacked), They all live pretty much in the same package, so it'd be easy to squash them down before merging to main, if we want to move this to a separate tool in the future. |
mahlunar
reviewed
Jun 10, 2024
Signed-off-by: Kasper J. Hermansen <[email protected]>
* feat: add registry and global storage Signed-off-by: Kasper J. Hermansen <[email protected]> * feat: remove bullet Signed-off-by: Kasper J. Hermansen <[email protected]> * feat: remember to initiate install Signed-off-by: Kasper J. Hermansen <[email protected]> * feat: make sure to check permissions Signed-off-by: Kasper J. Hermansen <[email protected]> * chore: make registry private Signed-off-by: Kasper J. Hermansen <[email protected]> * feat(extensions): with git operations (#222) * feat(extensions): with git operations Quite simply implements fetch and clone to make sure we can pull a registry Signed-off-by: Kasper J. Hermansen <[email protected]> * feat: add git registry Signed-off-by: Kasper J. Hermansen <[email protected]> * feat(extensions): add install extensions from registry (#223) * "feat(extensions): add install extensions from registry This pr includes everything up to actually downloading the extension from the upstream registry Such as pulling an example registry entry ```json { "name": "SuperExtender", "description": "Enhances your experience with superpowers.", "version": "1.0.3", "downloadUrls": [ { "architecture": "amd64", "os": "linux", "url": "https://example.com/linux/amd64/superextender.tar.gz", "checksum": "efgh5678" }, { "architecture": "x86", "os": "windows", "url": "https://example.com/windows/x86/superextender.zip", "checksum": "ijkl91011" }, { "architecture": "arm64", "os": "darwin", "url": "https://example.com/windows/x86/superextender.zip", "checksum": "ijkl91011" } ] } ``` Which will match on the current os using $GOOS and $GOARCH set by golang itself. We may however have to depend on some other variables if go is not installed by I believe it should work anyway" * feat: print error Signed-off-by: Kasper J. Hermansen <[email protected]> * fix: review comments, wording etc. Signed-off-by: Kasper J. Hermansen <[email protected]> * feat(extensions): add github release downloader (#224) * feat(extensions): add github release downloader This specifically adds a downloader for github releases it uses either the SHUTTLE_EXTENSIONS_GITHUB_ACCESS_TOKEN or GITHUB_ACCESS_TOKEN for access to the releases The downloader expects a full url from the registry as seen in a previous pr Signed-off-by: Kasper J. Hermansen <[email protected]> * chore: reword bearer Signed-off-by: Kasper J. Hermansen <[email protected]> * feat(extensions): add execute command (#225) * feat(extensions): add execute command this adds Extensions to the global cmd.go resulting in another section showing up when doing a shuttle --help To execute an extension simply shuttle myExtension where myExtension is the name of the downloaded extension. All args are passed to the child as well Signed-off-by: Kasper J. Hermansen <[email protected]> * feat: remember to add error Signed-off-by: Kasper J. Hermansen <[email protected]> * feat: without empty line Signed-off-by: Kasper J. Hermansen <[email protected]> * feat: adds github remote registry index (#226) * feat: with github registry Signed-off-by: Kasper J. Hermansen <[email protected]> * fix: shuttle extensions Signed-off-by: Kasper J. Hermansen <[email protected]> * feat: can download private files Signed-off-by: Kasper J. Hermansen <[email protected]> * feat: remove fluff Signed-off-by: Kasper J. Hermansen <[email protected]> * feat: fix review comments Signed-off-by: Kasper J. Hermansen <[email protected]> * feat: it needs to implement the functions Signed-off-by: Kasper J. Hermansen <[email protected]> --------- Signed-off-by: Kasper J. Hermansen <[email protected]> --------- Signed-off-by: Kasper J. Hermansen <[email protected]> --------- Signed-off-by: Kasper J. Hermansen <[email protected]> --------- Signed-off-by: Kasper J. Hermansen <[email protected]> --------- Signed-off-by: Kasper J. Hermansen <[email protected]> --------- Signed-off-by: Kasper J. Hermansen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a basic command palette for shuttle such as:
shuttle ext update
shuttle ext init
shuttle ext install
This also right now uses a skeleton implementation of a central ExtensionManager which is supposed to orchestrate these extensions. The call to the extensions will be done in a later PR
Builds on: #219