Skip to content

Commit

Permalink
tests: better test names
Browse files Browse the repository at this point in the history
  • Loading branch information
7HR4IZ3 committed Nov 20, 2024
1 parent 6bd0f8c commit 1024f88
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 60 deletions.
12 changes: 6 additions & 6 deletions e2e/logs.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ test("make a log public", async ({ page, context }) => {
});

// CSV EXPORTS
test("test export csv - llm", async ({ page }) => {
test("test export csv for llm", async ({ page }) => {
page.on("console", (msg) => {
console.log(msg);
});
Expand Down Expand Up @@ -84,7 +84,7 @@ test("test export csv - llm", async ({ page }) => {
// TODO: do the same thing for threads and traces (do not forget to check that children has the right)
});

// test("test export csv - trace", async ({ page }) => {
// test("test export csv for trace", async ({ page }) => {
// page.on("console", (msg) => {
// console.log(msg);
// });
Expand Down Expand Up @@ -118,7 +118,7 @@ test("test export csv - llm", async ({ page }) => {
// expect(Object.keys(logWithChildren[0])).toEqual(expectedHeaders);
// });

test("test export csv - thread", async ({ page }) => {
test("test export csv for thread", async ({ page }) => {
page.on("console", (msg) => {
console.log(msg);
});
Expand Down Expand Up @@ -168,7 +168,7 @@ test("test export csv - thread", async ({ page }) => {
});

// RAW JSONL
test("test export jsonl - llm", async ({ page }) => {
test("test export jsonl for llm", async ({ page }) => {
page.on("console", (msg) => {
console.log(msg);
});
Expand Down Expand Up @@ -224,7 +224,7 @@ test("test export jsonl - llm", async ({ page }) => {
]);
});

// test("test export jsonl - trace", async ({ page }) => {
// test("test export jsonl for trace", async ({ page }) => {
// page.on("console", (msg) => {
// console.log(msg);
// });
Expand All @@ -248,7 +248,7 @@ test("test export jsonl - llm", async ({ page }) => {
// expect(Object.keys(json)).toEqual(expectedHeaders);
// });

test("test export jsonl - thread", async ({ page }) => {
test("test export jsonl for thread", async ({ page }) => {
page.on("console", (msg) => {
console.log(msg);
});
Expand Down
54 changes: 2 additions & 52 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 0 additions & 2 deletions packages/backend/src/api/v1/runs/export.ts
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,6 @@ export async function fileExport(
}
}
}
yield "exports";
},
});
ctx.body = stream;
Expand All @@ -184,7 +183,6 @@ export async function fileExport(
yield line + "\n";
}
}
yield "exports";
},
});
ctx.body = stream;
Expand Down

0 comments on commit 1024f88

Please sign in to comment.