Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demonstrate multi-line comment reconstruction #1

Closed

Conversation

kezhuw
Copy link

@kezhuw kezhuw commented Nov 26, 2024

Changes:

  1. No change to one-line comment capture.
  2. Change only indentation and line separator for multi-line comment.

The reconstruction might be a bit hard given the current comment capture from apache#2206. I am OK to both approches.

luozongle01 and others added 2 commits November 21, 2024 22:03
Changes:
1. No change to one-line comment capture.
2. Change only indentation and line separator for multi-line comment.

The reconstruction might be a bit hard given the current comment
capture from apache#2206. I am OK to both approches.
@kezhuw
Copy link
Author

kezhuw commented Nov 26, 2024

I checked the generated file, and the format of comments are kept as origin given the changes in zookeeper.jute.

@luozongle01
Copy link
Owner

Changes:

  1. No change to one-line comment capture.
  2. Change only indentation and line separator for multi-line comment.

The reconstruction might be a bit hard given the current comment capture from apache#2206. I am OK to both approches.

Oh, I understand now. This way, the blank lines between multiple comments can also be maintained. Thank you very much. I will modify it accordingly.

@luozongle01 luozongle01 force-pushed the ZOOKEEPER-4880 branch 5 times, most recently from 374c55c to 0e49b5f Compare December 3, 2024 03:56
@kezhuw kezhuw closed this Dec 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants