Feat/join a ride

[lupyana]

• Create api end point and test case for joining a ride see Request to join a ride #43
• Added coveralls to project Integrate coveralls #47
• Updated readme file

[BenMaruchu]

@lupyana Coverage files ain't them generated on running tests?

[lupyana]

@lupyana Coverage files ain't them generated on running tests?

If you mean the coverage folder, it is auto generated after running tests

[BenMaruchu]

So what happens if tests are executed in travis?

[lupyana]

So what happens if tests are executed in travis?

Travis will build and perform the unit and coverage tests, After is is complete coverals will read the repo, to get results of the coverage test.It will prepare a report showing which parts of the code wasn’t covered by the test suites

[makoscafee]

All LGTM just one minor thing is coverage folder should not be committed, It is unnecessary. See. or you can see sample node .gitignore from here

[BenMaruchu]

ok @lupyana but I agree with @makoscafee from what I know coverage files are not committed in repos. I think @makoscafee have explained it well there

[lupyana]

ok @lupyana but I agree with @makoscafee from what I know coverage files are not committed in repos. I think @makoscafee have explained it well there

Yes noted, however it is already in my gitignore file. I have to find anotherway to remove it from the remote repo

[lupyana]

All LGTM just one minor thing is coverage folder should not be committed, It is unnecessary. See. or you can see sample node .gitignore from here

@makoscafee I have removed the coverage folder

[makoscafee]

LGTM you can merge.