Skip to content
This repository has been archived by the owner on Dec 27, 2022. It is now read-only.

Systemd Unit Update #448

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Systemd Unit Update #448

wants to merge 1 commit into from

Conversation

pmorton
Copy link
Contributor

@pmorton pmorton commented Feb 12, 2016

  • Make unit compatible with Logstash 2.2
    • Add heap dump path which 2.2 has now made a required variable
  • Remove soft file limit (systemd is not happy to set this)

@pmorton
- Make unit compatible with Logstash 2.2
dff57c5 
  - Add heap dump path which 2.2 has now made a required variable
- Remove soft file limit (systemd is not happy to set this)
willejs
willejs reviewed Jun 27, 2016
View reviewed changes
templates/default/init/systemd/tarball.erb
@@ -1,3 +1,17 @@
<% @full_java_opts = [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nicer to move this into a helper library perhaps?

@martinb3
Copy link
Collaborator

Hi there! I've recently hopped in to help on this cookbook; if you'd like to rebase this against master, and have us review/merge it, please do so. If this PR is too out of date, and you think it should be closed, please do that as well. Thank you!

@martinb3
Copy link
Collaborator

martinb3 commented Jun 1, 2017

This probably breaks compatibility and will require a version bump.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
breaking-change enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pmorton @martinb3 @willejs