Fix selafin special characters #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…les with non-ANSI character paths do not cause any problems
PeterPetrik
reviewed
Mar 21, 2024
mdal/mdal_utils.hpp
Outdated
| //! Deletes a file. Returns true on success, false otherwise | ||
| bool deleteFile( const std::string &path ); | ||
|
|
||
| //!renames a file. Returns true on success, false otherwise |
There was a problem hiding this comment.
//!renames -> //! Renames
mdal/mdal_utils.cpp
Outdated
| std::wstring wStr = converter.from_bytes( path ); | ||
| return DeleteFileW( wStr.c_str() ) != 0; | ||
| #else | ||
| return remove( path.c_str() ) == 0; |
PeterPetrik
approved these changes
Apr 8, 2024
|
Thanks! Could you make a patch version (1.1.1) for the last fixes? Or would that be too soon according to the roadmap? |
|
@uclaros ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #483
First off, a regression test (WriteDatasetSpecialCharacters) was written so that the issue at hand could be reproduced.
Then the issue was fixed. Some instances of std::string had to be converted to std::wstring followed by windows-specific system calls.
The solution is analogous to the way cross-platform strings are currently handled in mdal_utils.h/.cpp.