Replace regex_split with MDAL::split in mdal_mike21.cpp #496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sisting of a mix of tab characters and spaces, so we need to replace the tab characters with spaces before using the MDAL::split function to process the data.
uclaros
requested changes
Feb 14, 2025
…om function Co-authored-by: Stefanos Natsis <[email protected]>
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
uclaros
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mike21 dirver uses regular expressions to analyze text data, it is very slow.
regex_split test
$ time ./tools/mdalinfo ./tlgs.mesh
mdalinfo 1.3.0
Mesh File: ./tlgs.mesh
Mesh loaded: OK
Driver: Mike21
Vertex count: 146054
Edge count: 0
Face count: 279552
Edge count: 0
Projection: PROJCS["CGCS2000_3_Degree_GK_CM_117E"]
Datasets loaded: OK
Groups count: 2
VertexType
Bed Elevation
real 0m40.182s
user 0m38.331s
sys 0m0.030s
MDAL::split test
$ time ./tools/mdalinfo ./tlgs.mesh
mdalinfo 1.3.0
Mesh File: ./tlgs.mesh
Mesh loaded: OK
Driver: Mike21
Vertex count: 146054
Edge count: 0
Face count: 279552
Edge count: 0
Projection: PROJCS["CGCS2000_3_Degree_GK_CM_117E"]
Datasets loaded: OK
Groups count: 2
VertexType
Bed Elevation
real 0m2.458s
user 0m0.800s
sys 0m0.042s