Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for windows os #69

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

Logic-Bai
Copy link

Hi maintainers, I add support for windows OS, I hope this will help more people use this project in windows. I love use vscode to do software development.

@kisvegabor
Copy link
Member

Hi,

on Windows wouldn't it make more sense to use LVGL's Windows driver instead of SDL?

@Logic-Bai
Copy link
Author

Hi Kisvegabor,

Thank you so much for reviewing my pull request and providing your suggestions. Your work on LVGL has been a tremendous help to many people, and it’s an honor to receive your feedback!

I apologize for the delay in responding. I’ve been under a lot of work pressure recently, but I tested your approach as soon as I could, and it works perfectly. I really appreciate your guidance!

Regarding my original changes, they were based on my beginner experience with LVGL. I started with this simulator and used SDL2 because it was mentioned in the documentation. Your suggestion has shown me a much better way—thank you for pointing that out!

Would it be okay if I add your approach to this repository? I believe many beginners, especially Windows users, would benefit from an out-of-the-box solution here. While there is another repository that provides a similar setup, it uses Code::Blocks, which is less convenient for reading and modifying code compared to VSCode. Adding Windows support here could make this simulator even more beginner-friendly.

Thanks again for your time and help! I’m looking forward to hearing your thoughts.

@Logic-Bai
Copy link
Author

Hi Kisvegabor,

I read your suggestion and noticed you mentioned using Kconfig for project configuration, like:

#define LV_USE_WINDOWS 1  

However, I also saw a TODO note under the Kconfig section. Can I contribute to the Kconfig development or documentation?

I’m familiar with converting .config files into config.h. For example, I could enable generating lv_config.h from an lvgl.config file. After running:

cmake --build . --target menuconfig  

the .config and config.h files would be generated after configuration.

This comes from Zephyr. I adapted the approach and have successfully implemented it in a project I’m currently working on.

Looking forward to your thoughts!

@kisvegabor
Copy link
Member

It's my pleasure 🙂 And I'm also sorry for the delay.

However, I also saw a TODO note under the Kconfig section

Where do you see this "TODO" exactly?

Do you mean introducing Kconfig/config.h based config system for this repo? If so, I suggest proceeding gradually. Let's add Windows support to this repo, and figure out what to do next.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants