Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade mongoid 6 and rails 5 #132

Open
wants to merge 17 commits into
base: legacy-1.x
Choose a base branch
from

Conversation

ritxi
Copy link

@ritxi ritxi commented Aug 3, 2017

Keep same api but make it compatible with rails 5.x and mongoid 6.x

  • Basically I've just removed alias_method_chain
  • Remove some deprecation warnings

@aledalgrande
Copy link
Contributor

There are still quite a few projects on Rails 4, I would suggest not breaking compatibility with them.

@ritxi
Copy link
Author

ritxi commented Aug 5, 2017

I would suggest a 1.7 version with old simple_enum api, rails 5 and mongoid 6 compatibility. In my case I have a big project working with simple enum old api and I'm trying to upgrade to rails 5.

@lwe
Copy link
Owner

lwe commented Nov 16, 2017

Hey @ritxi, sorry for the late response, how can I help you with the Rails 5 related migrate and mongoid 6?

@lwe
Copy link
Owner

lwe commented Nov 16, 2017

TBH, according to semver it's very tricky to actually be able to provide a 1.x release that is breaking backwards compatibility.

@ritxi
Copy link
Author

ritxi commented Nov 16, 2017

Hi @lwe,

I just published this pull request if it would be helpful for somebody, I'm using it in production with success. I suggested you to do 1.7 release just to let people in the same situation as me to be able to upgrade newer rails/mongo versions without the need to upgrade to the new api.

@lwe
Copy link
Owner

lwe commented Nov 19, 2017

Are the changes backwards compatible towards Rails 4 and Mongodb 5?

@lwe
Copy link
Owner

lwe commented Dec 9, 2019

Hey @ritxi, I've seen that you did a recent change here. Anything I can do and anything required, that this can be applied to master - or is it just a backport?

@lwe lwe added the in progress label Dec 9, 2019
@ritxi
Copy link
Author

ritxi commented Dec 9, 2019

Hi,
this is just a backport to use old Api. I recently updated the gemspec to support latest rails version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants