Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fail when interpreting md footnote as link #1410

Closed
wants to merge 0 commits into from

Conversation

jan-ferdinand
Copy link

@mre
Copy link
Member

mre commented Aug 6, 2024

Uhm... I didn't want to close this?

@mre
Copy link
Member

mre commented Aug 6, 2024

Reopening

@mre
Copy link
Member

mre commented Aug 6, 2024

I think I locked myself out of this one. Looks like I don't have permission to push to your fork @jan-ferdinand. 😅

@jan-ferdinand
Copy link
Author

I'm unsure what went wrong and how you would like to continue. 😌

@mre
Copy link
Member

mre commented Aug 11, 2024

I don't know how exactly it worked either, but I think I tried to update your branch with my fix and that failed. Somehow the changeset was empty and that auto-closed the pull request. No idea.

Anyhow, after I realized my mistake, I created this new branch with the fix: #1479
I think it's ready to be merged to get the bug fixed.


Side note for the future: it's better to create a new branch on your fork, which describes the problem instead of using master. So for example jan-ferdinand:footnote-link or so. This makes it a little easier to see which branch I'm on when I'm working from the commandline and also keeps the changes in this new branch separate from master, which is usually a clone of the upstream master. It would not have prevented my mistake, though; just best-practice.

@jan-ferdinand
Copy link
Author

Makes perfect sense. 👍 Next time. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants