Remove cross-spawn as a dependency #66
Draft
+56
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
lishaduck
reviewed
Sep 25, 2024
| @@ -15,6 +15,7 @@ | |||
| "@types/ws": "8.5.4", | |||
| "@typescript-eslint/eslint-plugin": "5.48.2", | |||
| "@typescript-eslint/parser": "5.48.2", | |||
| "cross-spawn": "7.0.3", | |||
There was a problem hiding this comment.
You moved this to dependencies, not devDependencies 🙃
There was a problem hiding this comment.
I was tired. I meant that you moved it to devDependencies, rather than removing it, and this didn't modify any tests.
There was a problem hiding this comment.
Yes, the point of the PR was to remove it from the actual package. The tests could be dealt with later (if at all, depending on what shenanigans I pulled there).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.