Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure S3 bucket #80

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Ensure S3 bucket #80

wants to merge 2 commits into from

Conversation

sergeyt
Copy link
Contributor

@sergeyt sergeyt commented Feb 8, 2020

This change is Reviewable

@codecov-io
Copy link

codecov-io commented Feb 8, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@c6a88c7). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master     #80   +/-   ##
========================================
  Coverage          ?   21.1%           
========================================
  Files             ?      13           
  Lines             ?    2080           
  Branches          ?       0           
========================================
  Hits              ?     439           
  Misses            ?    1573           
  Partials          ?      68
Impacted Files Coverage Δ
awss3/store.go 0.28% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6a88c7...0bc159d. Read the comment docs.


s3Client := s3.New(sess)

ensureBucket(s3Client, conf.Bucket)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sergeyt shouldn't you be checking the error returned from this function?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@epsniff yes, but only network connections I guess. if bucket exists should be no error


s3Client := s3.New(sess)

ensureBucket(s3Client, conf.Bucket)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ensureBucket(s3Client, conf.Bucket)
err = ensureBucket(s3Client, conf.Bucket)
if err != nil {
return nil, nil, err
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants