-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure S3 bucket #80
base: master
Are you sure you want to change the base?
Ensure S3 bucket #80
Conversation
Codecov Report
@@ Coverage Diff @@
## master #80 +/- ##
========================================
Coverage ? 21.1%
========================================
Files ? 13
Lines ? 2080
Branches ? 0
========================================
Hits ? 439
Misses ? 1573
Partials ? 68
Continue to review full report at Codecov.
|
|
||
s3Client := s3.New(sess) | ||
|
||
ensureBucket(s3Client, conf.Bucket) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sergeyt shouldn't you be checking the error returned from this function?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@epsniff yes, but only network connections I guess. if bucket exists should be no error
|
||
s3Client := s3.New(sess) | ||
|
||
ensureBucket(s3Client, conf.Bucket) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ensureBucket(s3Client, conf.Bucket) | |
err = ensureBucket(s3Client, conf.Bucket) | |
if err != nil { | |
return nil, nil, err | |
} |
This change is