YAML with anchors and aliases is broken

[systemmonkey42]

Description

Valid YAML file containing anchors and aliases/merge points is broken by yamlfix

Current behavior

Source yaml: This is a snippet from docker-compose.yml, trimmed to focus on the issue

x-node-volumes: &node-volumes
  node3_data:

x-vault-volumes: &vault-volumes
  vault_data:

x-mongo-volumes: &mongo-volumes
  mongo_data:

x-certmgr-volumes: &certmgr-volumes
  cert_data:

volumes:
  <<: *node-volumes
  <<: *vault-volumes
  <<: *mongo-volumes
  <<: *certmgr-volumes

Result:

---
x-node-volumes: &node-volumes
  node3_data:

x-vault-volumes:
  vault_data:

x-mongo-volumes: &mongo-volumes
  mongo_data:

x-certmgr-volumes:
  cert_data:

volumes:
  <<: *node-volumes
  <<: *mongo-volumes

Desired behavior

• no change. Document is already formatteed

In this specific example, during YAML processing, the "volumes" map no longer contains all the volumes once yamlfix has processed the file.

Side node: Using a different method to aggregate the anchors produces correct results

volumes:
  <<: [*node-volumes, *vault-volumes, *mongo-volumes, *certmgr-volumes]

Environment

• Ubuntu 20.04
• Yamlfix version

$ yamlfix --version
              yamlfix version: 0.7.2
               python version: 3.8.10 (default, Jun  2 2021, 10:49:15)  [GCC 9.4.0]
                     platform: Linux-5.8.0-64-generic-x86_64-with-glibc2.29

[lyz-code]

Hi @systemmonkey42, thanks for taking the time to open the issue. Sadly, I won't be able to look into it this month as I'm a little bit overloaded, maybe one of the other maintainers can jump in.

If you can't wait and have coding skills and some time, feel free to make a pull request.

[muripic]

I've been running some tests to find the root cause for this and looks like it's coming from ruyaml. This is the only related issue I could find: pycontribs/ruyaml#50.

If I manage to fix it I'll send a PR to ruyaml.

[muripic]

It was already fixed 😃 Only that they are not uploading the latest versions to pypi (I created an issue for this).

I upgraded the dependency and it works (build is failing due to issues with other dependencies but will try to fix them ASAP):
#122

[lyz-code]

Awesome! thanks @muripic :)

[lyz-code]

Until pycontribs/ruyaml#58 is resolved, I'll reopen this issue because we can't
hardcode dependencies from github in the setup.py as Pypi doesn't allow
them.

If you need that feature, please change the "ruyaml" line in the
setup.py with:

"ruyaml @ git+git://github.com/pycontribs/[email protected]#egg=ruyaml", # noqa E800

and run make install.

[lyz-code]

It's merged already