Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert the ruyaml dependency #138

Merged
merged 1 commit into from
Nov 26, 2021
Merged

Conversation

lyz-code
Copy link
Owner

Until pycontribs/ruyaml#58 is resolved, the issue
#120 will remain because we can't
hardcode dependencies from github in the setup.py because Pypi doesn't allow
them.

If you need that feature, please change the "ruyaml" line in the
setup.py with:

"ruyaml @ git+git://github.com/pycontribs/[email protected]#egg=ruyaml", # noqa E800

and run make install.

Checklist

  • Add test cases to all the changes you introduce
  • Update the documentation for the changes

Until pycontribs/ruyaml#58 is resolved, the issue
#120 will remain because we can't
hardcode dependencies from github in the `setup.py` because Pypi doesn't allow
them.

If you need that feature, please change the "ruyaml" line in the
`setup.py` with:

```python
"ruyaml @ git+git://github.com/pycontribs/[email protected]#egg=ruyaml", # noqa E800
```

and run `make install`.
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1507006588

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 1506973689: 0.0%
Covered Lines: 150
Relevant Lines: 150

💛 - Coveralls

@lyz-code lyz-code merged commit 51433d2 into master Nov 26, 2021
@lyz-code lyz-code deleted the fix/revert-ruyaml-dependency branch June 10, 2022 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants