Fix for case where no aligned_alloc #559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evaleev
approved these changes
Dec 3, 2024
There was a problem hiding this comment.
@EricaCMitchell strictly speaking, this is backwards:
- we want to prefer standard things to non-standard things, and we want to prefer C++ to C.
- so std::aligned should be used first. But this means we should check for it in cmake
- cmake provides no good 1-liner to check for C++ functions reliably so need O(10) lines.
This will work. The notes are for the future. Be OCD.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #558.
If HAVE_POSIX_MEMALIGN then use
posix_memalignoveraligned_alloc.