Triton Attention #22
Open
Triton Attention #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Sean Zhang <[email protected]>
…direction (#4) * Changed the timing function to just compile and warm up the relevant direction * Bugfix
* add theoretical and walltime * small is better * add in script for plotting * add comparison plots * add rebased * wip * Updated some stuff * wip * wip * Incomplete impl * Added assert * Updated compare2 with jacob version of triton kernel * Changed the timing function to just compile and warm up the relevant direction * Removed triton power again for now * delete unused code * address comments, merge compare * nit * Update pyproject.toml * done * need torch to build * use the right pip * use python module for pip and pytest * build requires torch * land this thing now --------- Co-authored-by: Sean Zhang <[email protected]> Co-authored-by: Jacob Buckman <[email protected]>
* add mode to comapre * added run_baseline * add run_baseline and profile_baseline * remove unnecessary import * better measurement --------- Co-authored-by: Sean Zhang <[email protected]>
* Fixed flops and regenerated plots to add to README * Update * Update
* triton update fwd done * bwd passed * better order * add benchmark * compile on the fly, no second run * deterministic conditions * 2 for loops, additional 4% speed up * remove unnecessary variable * functional query_state * update_state passing all tests; improved _inspect.py a bit * all passing * add power_full_triton * use print_runtime * use print_runtime * limit torch versio --------- Co-authored-by: Sean Zhang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements power_attention interface with multiple read and writes for any p in log space.
Not tested yet