Skip to content

Commit

Permalink
remove obsolete TODOs
Browse files Browse the repository at this point in the history
  • Loading branch information
gfr10598 committed May 1, 2019
1 parent ba2bfdc commit 0fc1ea2
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions cloud/bq/sanity.go
Original file line number Diff line number Diff line change
Expand Up @@ -107,8 +107,6 @@ func (at *AnnotatedTable) CachedDetail(ctx context.Context) (*Detail, error) {
if ctx == nil {
return nil, ErrNilContext
}
// TODO - use context
// TODO - maybe just embed code here.
at.detail, at.err = GetTableDetail(ctx, at.dataset, at.Table)
if at.err != nil {
log.Println(at.FullyQualifiedName(), at.TableID())
Expand All @@ -130,8 +128,6 @@ func (at *AnnotatedTable) CachedPartitionInfo(ctx context.Context) (*dataset.Par
if ctx == nil {
return nil, ErrNilContext
}
// TODO - use context
// TODO - maybe just embed code here.
at.pInfo, at.err = at.GetPartitionInfo(ctx)
return at.pInfo, at.err
}
Expand Down Expand Up @@ -173,7 +169,6 @@ func GetTableDetail(ctx context.Context, dsExt *dataset.Dataset, table bqiface.T
%s -- where clause`,
dataset, tableName, where)

// TODO - this should take a context?
err := dsExt.QueryAndParse(ctx, queryString, &detail)
if err != nil {
log.Println(err)
Expand Down

0 comments on commit 0fc1ea2

Please sign in to comment.