Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ndt7 and annotation to bq_gardener_parse_time #732

Merged
merged 1 commit into from
Aug 19, 2020

Conversation

gfr10598
Copy link
Contributor

@gfr10598 gfr10598 commented Aug 18, 2020

The travis build triggered one deployment, but looking at BQ logs, it doesn't seem to have changed the query that was run.


This change is Reviewable

Copy link
Contributor

@stephen-soltesz stephen-soltesz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a long standing bug in the bq exporter that you have to manually bounce the pod to get it to pickup configmap/query changes.

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @stephen-soltesz)

@gfr10598 gfr10598 merged commit c0abe23 into master Aug 19, 2020
@gfr10598 gfr10598 deleted the sandbox-parse-time branch August 19, 2020 01:23
@stephen-soltesz
Copy link
Contributor

I created a known-issue issue for this issue #734

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants