Streaming FIFO: Signals Read/Write Availability using Watermarks #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
misoc/interconnect/stream.py
Outdated
| @@ -78,13 +78,122 @@ def __init__(self, fifo_class, layout, depth): | |||
| self.fifo.re.eq(self.source.ack) | |||
| ] | |||
|
|
|||
| if hi_wm is not None: | |||
| self.fifo.add_almost_full(hi_wm) | |||
There was a problem hiding this comment.
Why not create the FIFO with the watermarks in the first place, instead of calling such functions?
This explanation should be in code comments and/or docstrings, not just in this PR description. |
Burst validity should be enforced by the master.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adjusts the
stb/ackcontrol signal behavior of FIFOs with watermarks. FIFO only signals availability when a complete packet/burst can be transferred.ackcan be asserted when the FIFO has a complete packet, ready to receiveeopis not considered in this case, as packet length is likely unknownstbcan be asserted when the FIFO has a complete packet, ready to sendeopis respectedRelated PR
See migen 294.