remove duplicate code in notebooks, analysis/
#111
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Jupyter notebooks were updated to run correctly in previous commits, but they often used functions in the
analysis/
folder which weren't used in the main library, and these weren't inspected. So we have two slightly different ways of e.g. obtaining CM2.6 ocean velocity data.Also, a
GlobalPlotter
class defined inanalysis/
is duplicated in some of the notebooks, with some changes (e.g. to keys used for the input dataset). At a glance these should be mergeable into a single instance.get_patch
,get_whole_data
with calls tolib.data
functionsGlobalPlotter
class