Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove duplicate code in notebooks, analysis/ #111

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

raehik
Copy link
Contributor

@raehik raehik commented Dec 12, 2023

The Jupyter notebooks were updated to run correctly in previous commits, but they often used functions in the analysis/ folder which weren't used in the main library, and these weren't inspected. So we have two slightly different ways of e.g. obtaining CM2.6 ocean velocity data.

Also, a GlobalPlotter class defined in analysis/ is duplicated in some of the notebooks, with some changes (e.g. to keys used for the input dataset). At a glance these should be mergeable into a single instance.

  • replace get_patch, get_whole_data with calls to lib.data functions
  • have just one GlobalPlotter class

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@raehik raehik changed the title deduplicate common GlobalPlotter used in figure generation remove duplicate code in notebooks, analysis/ Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant