Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: SQDSDKS-5855 - Identity caching #452

Open
wants to merge 5 commits into
base: development
Choose a base branch
from

Conversation

markvdouw
Copy link

@markvdouw markvdouw commented Nov 17, 2023

Checking if we should make an identiy call or return saved MParticleUser based on last request (using timeout) and several conditions.

Instructions

  1. PR target branch should be against development
  2. PR title name should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-title-check.yml
  3. PR branch prefix should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-branch-check-name.yml

Summary

  • Adding logic to check if an identity request should be done or no based on mpId, userIdentities and params such as deviceId and googleId (implementation needed) as well as timeout and lastTime request was made.

Testing Plan

  • Was this tested locally? If not, explain why.
  • {explain how this has been tested, and what, if any, additional testing should be done}

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

@markvdouw markvdouw requested a review from einsteinx2 January 10, 2024 11:24
@markvdouw markvdouw marked this pull request as ready for review January 10, 2024 11:25
@samdozor samdozor force-pushed the development branch 4 times, most recently from 4759c74 to a831780 Compare March 2, 2024 02:49
@rmi22186 rmi22186 force-pushed the development branch 4 times, most recently from fca8a44 to b67c108 Compare May 29, 2024 19:20
@Mansi-mParticle Mansi-mParticle force-pushed the feat/SQDSDKS-5855_identity_caching branch from 66b0ce8 to 8e1b0da Compare August 22, 2024 15:29
@Mansi-mParticle Mansi-mParticle force-pushed the feat/SQDSDKS-5855_identity_caching branch from 8e1b0da to 405d853 Compare September 12, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant