New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support direct URL routing #499

Merged

einsteinx2 merged 19 commits into development from feat/SQDSDKS-pod_redirection_2

Aug 13, 2024

Contributor

Mansi-mParticle commented Jul 12, 2024

Instructions

PR target branch should be against development
PR title name should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-title-check.yml
PR branch prefix should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-branch-check-name.yml

Summary

Cherry-pick commits from old branch feat: SQDSDKS-5914 - Pod redirection #447 , routing data to endpoints.

Testing Plan

Was this tested locally? If not, explain why.
Tested with sample application and executed unit test case

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

Closes https://go.mparticle.com/work/SQDSDKS-6550

Mansi-mParticle changed the title ~~Feat/sqdsdks pod redirection 2~~ eat: SQDSDKS-5914 - Pod redirection 2

Mansi-mParticle changed the title ~~eat: SQDSDKS-5914 - Pod redirection 2~~ feat: SQDSDKS-5914 - Pod redirection 2

Mansi-mParticle requested review from samdozor and rmi22186

July 12, 2024 20:04

Mansi-mParticle changed the title ~~feat: SQDSDKS-5914 - Pod redirection 2~~ feat: Support direct URL routing

Mansi-mParticle requested a review from BrandonStalnaker

July 15, 2024 15:02

BrandonStalnaker requested changes

View reviewed changes

Contributor

BrandonStalnaker left a comment •

edited

Loading

The unit tests look good and I don't see any issues with the logic but I did find some logs that I think got leftover in testing.

android-core/src/main/java/com/mparticle/networking/MParticleBaseClientImpl.java Outdated Show resolved Hide resolved

android-core/src/main/java/com/mparticle/networking/MParticleBaseClientImpl.java Outdated Show resolved Hide resolved

rmi22186 requested changes

View reviewed changes

Member

rmi22186 left a comment

Looks and works great overall. I think there are some areas that can be refactored to be more understandable.

android-core/src/main/java/com/mparticle/internal/ConfigManager.java Outdated Show resolved Hide resolved

android-core/src/main/java/com/mparticle/networking/NetworkOptionsManager.java Show resolved Hide resolved

android-core/src/main/java/com/mparticle/internal/ConfigManager.java Show resolved Hide resolved

android-core/src/main/kotlin/com.mparticle/NetworkUtilities.kt Outdated Show resolved Hide resolved

android-core/src/main/kotlin/com.mparticle/NetworkUtilities.kt Outdated Show resolved Hide resolved

android-core/src/main/kotlin/com.mparticle/NetworkUtilities.kt Outdated Show resolved Hide resolved

android-core/src/main/java/com/mparticle/networking/MParticleBaseClientImpl.java Outdated Show resolved Hide resolved

Mansi-mParticle requested review from rmi22186 and BrandonStalnaker

July 16, 2024 17:07

rmi22186 reviewed

View reviewed changes

android-core/src/androidTest/kotlin/com.mparticle/networking/MParticleBaseClientImplTest.kt Show resolved Hide resolved

Mansi-mParticle requested a review from rmi22186

July 24, 2024 20:17

rmi22186 reviewed

View reviewed changes

android-core/src/main/java/com/mparticle/internal/ConfigManager.java Show resolved Hide resolved

rmi22186 requested changes

View reviewed changes

android-core/src/main/java/com/mparticle/internal/ConfigManager.java Outdated Show resolved Hide resolved

android-core/src/main/java/com/mparticle/internal/ConfigManager.java Show resolved Hide resolved

android-core/src/main/java/com/mparticle/internal/ConfigManager.java Outdated Show resolved Hide resolved

android-core/src/main/java/com/mparticle/networking/NetworkOptions.java Outdated Show resolved Hide resolved

android-core/src/androidTest/kotlin/com.mparticle/networking/AccessUtils.kt Outdated Show resolved Hide resolved

Mansi-mParticle requested a review from rmi22186

August 2, 2024 23:06

rmi22186 requested a review from einsteinx2

August 7, 2024 13:37

Mansi-mParticle force-pushed the feat/SQDSDKS-pod_redirection_2 branch from 41bc426 to dfd42cf Compare

August 7, 2024 13:39

rmi22186 reviewed

View reviewed changes

android-core/src/main/java/com/mparticle/internal/ConfigManager.java Outdated Show resolved Hide resolved

rmi22186 reviewed

View reviewed changes

android-core/src/main/java/com/mparticle/internal/ConfigManager.java Outdated Show resolved Hide resolved

rmi22186 reviewed

View reviewed changes

android-core/src/androidTest/kotlin/com.mparticle/networking/MParticleBaseClientImplTest.kt Outdated Show resolved Hide resolved

rmi22186 reviewed

View reviewed changes

android-core/src/androidTest/kotlin/com.mparticle/networking/MParticleBaseClientImplTest.kt Show resolved Hide resolved

einsteinx2 reviewed

View reviewed changes

android-core/src/androidTest/kotlin/com.mparticle/networking/MParticleBaseClientImplTest.kt Show resolved Hide resolved

android-core/src/androidTest/kotlin/com.mparticle/networking/NetworkOptionsTest.kt Outdated Show resolved Hide resolved

android-core/src/main/java/com/mparticle/internal/ConfigManager.java Show resolved Hide resolved

android-core/src/main/java/com/mparticle/networking/MParticleBaseClientImpl.java Outdated Show resolved Hide resolved

Mansi-mParticle requested review from rmi22186 and einsteinx2

August 7, 2024 16:41

einsteinx2 approved these changes

View reviewed changes

Collaborator

einsteinx2 left a comment

lgtm

rmi22186 approved these changes

View reviewed changes

Member

rmi22186 left a comment

Approved, but let's wait for Sam's confirmation about the build.gradle URL files and its relationship to this feature.

rmi22186 reviewed

View reviewed changes

android-core/src/androidTest/kotlin/com.mparticle/networking/NetworkOptionsTest.kt Show resolved Hide resolved

Mansi-mParticle requested a review from rmi22186

August 8, 2024 16:10

rmi22186 reviewed

View reviewed changes

android-core/src/androidTest/kotlin/com.mparticle/networking/NetworkOptionsTest.kt Outdated Show resolved Hide resolved


          Change on access utils function

a82802d

Mansi-mParticle and others added 17 commits

August 9, 2024 17:02


          feat: SQDSDKS-5914 - Pod redirection -2

84fc41c


          fix unit test cases

1952aee


          remove test log

da0c856


          Address review comments

a999215


          handle domain mapping

2b0d738


          address review comments

5d7451a


          remove test method,use method from the config class

434bd2f


          address review comment

85b5f78


          fix: Remove recursion from the method and add default URL generation. (…

84ce09f

…#501)


          Address review comments, remove commented test case

acb223c


          Resolve the merge conflict

addeb2b


          fix lint error

2c410eb


          Link to Jira ticket for detailed information.

7be9e19


          Remove extra space

355d2d7


          Correct reference link

7cd4886


          address review comment

6cf1bef


          Refactor code for improved readability

c1ad77b

Mansi-mParticle force-pushed the feat/SQDSDKS-pod_redirection_2 branch from bc10d62 to c1ad77b Compare

August 9, 2024 21:02

rmi22186 reviewed

View reviewed changes

android-core/src/main/java/com/mparticle/networking/MParticleBaseClientImpl.java Outdated Show resolved Hide resolved


          Add a reference link for additional context

d1a9dce

Mansi-mParticle requested a review from rmi22186

August 12, 2024 15:25

rmi22186 approved these changes

View reviewed changes

samdozor approved these changes

View reviewed changes

BrandonStalnaker approved these changes

View reviewed changes

einsteinx2 merged commit d7aa30c into development

23 checks passed

einsteinx2 deleted the feat/SQDSDKS-pod_redirection_2 branch

August 13, 2024 16:02

mparticle-automation added a commit that referenced this pull request


          chore: 5.57.0 (release)

94284f5

## [5.57.0](v5.56.5...v5.57.0) (2024-08-13)

### Features

* Support direct URL routing ([#499](#499)) ([d7aa30c](d7aa30c))

### Bug Fixes

* Crash in KitConfiguration due to NumberFormatException ([#503](#503)) ([e1a23e7](e1a23e7))

Collaborator

mparticle-automation commented Aug 13, 2024

🎉 This PR is included in version 5.57.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

mparticle-automation added the released label

rmi22186 mentioned this pull request

feat: SQDSDKS-5914 - Pod redirection #447

Closed

1 task

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels