Eliminate warning message and formatten examples code #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
```
[10/839] Building CXX object CMakeFiles/mros2-mbed.dir/platform/mros2-platform.cpp.obj
In file included from /__w/mros2-mbed/mros2-mbed/mros2/embeddedRTPS/include/rtps/entities/StatefulReader.h:31,
from /__w/mros2-mbed/mros2-mbed/mros2/embeddedRTPS/include/rtps/discovery/BuiltInEndpoints.h:28,
from /__w/mros2-mbed/mros2-mbed/mros2/embeddedRTPS/include/rtps/discovery/SEDPAgent.h:28,
from /__w/mros2-mbed/mros2-mbed/mros2/embeddedRTPS/include/rtps/entities/Participant.h:30,
from /__w/mros2-mbed/mros2-mbed/mros2/embeddedRTPS/include/rtps/entities/Domain.h:30,
from /__w/mros2-mbed/mros2-mbed/mros2/embeddedRTPS/include/rtps/rtps.h:28,
from /__w/mros2-mbed/mros2-mbed/mros2/include/mros2.h:5,
from /__w/mros2-mbed/mros2-mbed/platform/mros2-platform.cpp:17:
/__w/mros2-mbed/mros2-mbed/mros2/embeddedRTPS/include/rtps/entities/Reader.h:74:3: warning: type qualifiers ignored on function return type [-Wignored-qualifiers]
74 | const DataSize_t getDataSize() const { return size; }
| ^~~~~
/__w/mros2-mbed/mros2-mbed/platform/mros2-platform.cpp: In function 'nsapi_error_t mros2_platform::network_connect()':
/__w/mros2-mbed/mros2-mbed/platform/mros2-platform.cpp:58:24: warning: format '%d' expects argument of type 'int*', but argument 3 has type 'std::array<unsigned char, 4>::value_type*' {aka 'unsigned char*'} [-Wformat=]
58 | sscanf(ip_address, "%d.%d.%d.%d", &ipaddr[0], &ipaddr[1], &ipaddr[2], &ipaddr[3]);
| ~^
| |
| int*
| %hhd
/__w/mros2-mbed/mros2-mbed/platform/mros2-platform.cpp:58:27: warning: format '%d' expects argument of type 'int*', but argument 4 has type 'std::array<unsigned char, 4>::value_type*' {aka 'unsigned char*'} [-Wformat=]
58 | sscanf(ip_address, "%d.%d.%d.%d", &ipaddr[0], &ipaddr[1], &ipaddr[2], &ipaddr[3]);
| ~^
| |
| int*
| %hhd
/__w/mros2-mbed/mros2-mbed/platform/mros2-platform.cpp:58:30: warning: format '%d' expects argument of type 'int*', but argument 5 has type 'std::array<unsigned char, 4>::value_type*' {aka 'unsigned char*'} [-Wformat=]
58 | sscanf(ip_address, "%d.%d.%d.%d", &ipaddr[0], &ipaddr[1], &ipaddr[2], &ipaddr[3]);
| ~^
| |
| int*
| %hhd
/__w/mros2-mbed/mros2-mbed/platform/mros2-platform.cpp:58:33: warning: format '%d' expects argument of type 'int*', but argument 6 has type 'std::array<unsigned char, 4>::value_type*' {aka 'unsigned char*'} [-Wformat=]
58 | sscanf(ip_address, "%d.%d.%d.%d", &ipaddr[0], &ipaddr[1], &ipaddr[2], &ipaddr[3]);
| ~^
| |
| int*
| %hhd
```
```
/__w/mros2-mbed/mros2-mbed/workspace/pub_camera_image/app.cpp: In member function 'void OV7670::WriteBy(int)':
/__w/mros2-mbed/mros2-mbed/workspace/pub_camera_image/app.cpp:111:22: warning: suggest parentheses around '-' inside '>>' [-Wparentheses]
111 | tempo=addr>>7-i;
| ~^~
```
…ing message
```
In file included from /__w/mros2-mbed/mros2-mbed/mros2/include/mros2.h:9,
from /__w/mros2-mbed/mros2-mbed/workspace/mturtle_teleop/app.cpp:17:
/__w/mros2-mbed/mros2-mbed/workspace/mturtle_teleop/app.cpp: In function 'int main()':
/__w/mros2-mbed/mros2-mbed/workspace/mturtle_teleop/app.cpp:116:18: warning: zero-length gnu_printf format string [-Wformat-zero-length]
116 | MROS2_INFO("");
| ^~
/__w/mros2-mbed/mros2-mbed/mros2/include/mros2/logging.h:46:12: note: in definition of macro 'MROS2_INFO'
46 | printf(__VA_ARGS__); \
| ^~~~~~~~~~~
/__w/mros2-mbed/mros2-mbed/workspace/mturtle_teleop/app.cpp:88:10: warning: variable 'fds' set but not used [-Wunused-but-set-variable]
88 | pollfh fds[1];
| ^~~
/__w/mros2-mbed/mros2-mbed/workspace/mturtle_teleop/app.cpp:95:8: warning: unused variable 'c' [-Wunused-variable]
95 | char c;
| ^
```
s-hosoai
approved these changes
Oct 5, 2023
| result ^= current[i]; | ||
| result = crc32_for_byte(result); | ||
| } | ||
|
|
||
|
|
||
| return ~result; | ||
| } | ||
|
|
||
| const char long_text[] = | ||
| #include "long_text.txt" |
There was a problem hiding this comment.
こんなんできるのか．確かにプリプロセスで展開してるだけですもんね．
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see each commit message for more details