Fix hanging of WebSocket::stop() waiting for its thread to join #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've just updated the PR to match the |
This might happen in some special cases where WebSocketTransport::sendOnSocket() fails, closes the socket, and set the ready state to CLOSED, but WebSocket::run() stills wait the interrupt event to happen. Possibly related to machinezone#474
|
Finally updated this PR as a specific test (IXWebSocketTestConnectionDisconnection) was failing. Now all tests pass. |
dacap
added a commit
to aseprite/aseprite
that referenced
this pull request
Aug 29, 2023
This can happen using Pribambase extension when we close Aseprite in some strange way (e.g. killing the process), and the connection is not closed correctly. It looks like the Blender addon is in an invalid state and the data cannot be sent any more, but without this patch Aseprite just hangs/crashes if we retry sending data, but with this fix we can receive/show that an error happened sending data. Related to: machinezone/IXWebSocket#481
|
looking good ci wise, re-ran them. |
|
thanks @dacap |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might happen in some special cases where
WebSocketTransport::sendOnSocket()fails, closes the socket, and set the ready state to CLOSED, butWebSocket::run()stills wait the interrupt event to happen.Possibly related to #474.