Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow building when cpp exceptions are disabled #488

Closed
wants to merge 1 commit into from
Closed

allow building when cpp exceptions are disabled #488

wants to merge 1 commit into from

Conversation

arenevier
Copy link
Contributor

IXWebSocket needs exceptions support because of the use of stoi. In order to build when cpp exceptions are disabled, we can use strtol when __cpp_exceptions is not set

@arenevier
allow building when cpp exceptions are disabled
2f35a8f 
IXWebSocket needs exceptions support because of the use of stoi. In
order to build when cpp exceptions are disabled, we can use strtol when
__cpp_exceptions is not set
@bsergean
Copy link
Collaborator

Windows / gcc is not happy. Can we switch to your new code all the time ?

@arenevier
Copy link
Contributor Author

Are you talking about the build error?

 | Cannot find path
 | 'C:\ProgramData\chocolatey\lib\mingw\tools\install\mingw64\x86_64-w64-mingw32\lib\libpthread.dll.a' because it
 | does not exist.

I'm not sure how it can be related to this change.

@arenevier
Copy link
Contributor Author

Anyway, I have created an alternative pull request with only the exception safe codepath: #489

@bsergean bsergean closed this Oct 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arenevier @bsergean