Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dectalk: multiple fixes to the port #26503

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

barracuda156
Copy link
Contributor

Description

Backport some upstream fixes.
Enable normal patching.
Fix building with gcc.
Fix build on Darwin < 16.

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 10.6
Xcode 3.2

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL in commit message?
  • checked your Portfile with port lint --nitpick?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

@macportsbot
Copy link

Notifying maintainers:
@mohd-akram for port dectalk.

@mohd-akram
Copy link
Member

Builds are failing, converted to draft.

@barracuda156
Copy link
Contributor Author

@mohd-akram I will rebase today, dropping my patches in favor of new backports from upstream, and we can see from there.

@reneeotten
Copy link
Contributor

ping

@barracuda156
Copy link
Contributor Author

I think by now all patches have been merged to upstream, so what is left from my side is a) fixing EOLs so that patching is less painful (no effect on the code), b) blacklisting archaic Xcode gcc (no effect on anything 10.6+ in MacPorts) and c) using legacy-support to provide clock_gettime (show be uncontroversial, and no effect on Darwin > 15).

Opportunistic linking to pulseaudio is fixed in upstream, but requires autotools build to regenerate configure sctipt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

4 participants