Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beets: allow installing minimal version on legacy systems, fix dependencies #26506

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

barracuda156
Copy link
Contributor

Description

See commits.

Likely this is not gonna pass CI, since it requires a lot of ports, and uses python310.

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 10.6
Xcode 3.2

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL in commit message?
  • checked your Portfile with port lint --nitpick?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

@barracuda156
Copy link
Contributor Author

@reneeotten I am dropping py38 subport from py-py7zr, since it breaks CI due to some dependencies not building or not existing anymore. This is a nomaintainer port with no dependents for py38 version.

audio/beets/Portfile Show resolved Hide resolved
@reneeotten
Copy link
Contributor

can you please rebase with master so we can see if the CI (or at least as much as possible) - right now it fails immediately with a parse error, which I assume has been resolved by now.

@barracuda156
Copy link
Contributor Author

can you please rebase with master so we can see if the CI (or at least as much as possible) - right now it fails immediately with a parse error, which I assume has been resolved by now.

Done

@barracuda156
Copy link
Contributor Author

Ok, now it is just a missing dep in a subport:

  ERROR Missing dependencies:
  	build
  	importlib-metadata>=4.6
  Command failed:  cd "/opt/local/var/macports/build/_Users_runner_work_macports-ports_macports-ports_ports_python_py-py7zr/py39-py7zr/work/py7zr-0.22.0" && /opt/local/Library/Frameworks/Python.framework/Versions/3.9/bin/python3.9 -m build --no-isolation --wheel --outdir /opt/local/var/macports/build/_Users_runner_work_macports-ports_macports-ports_ports_python_py-py7zr/py39-py7zr/work 
  Error: Failed to build py39-py7zr: command execution failed
  DEBUG: Error code: CHILDSTATUS 93131 1
  DEBUG: Backtrace: command execution failed
      while executing
  "system {*}$notty {*}$callback {*}$nice $fullcmdstring"
      invoked from within
  "command_exec -callback portprogress::target_progress_callback build"
      (procedure "portbuild::build_main" line 10)
      invoked from within
  "$procedure $targetname"
  Exit code: 1
  Error: See /opt/local/var/macports/logs/_Users_runner_work_macports-ports_macports-ports_ports_python_py-py7zr/py39-py7zr/main.log for details.
  Error: Follow https://guide.macports.org/#project.tickets if you believe there is a bug.
  Error: Processing of port py39-py7zr failed
  Build of 'py39-py7zr' failed.

@barracuda156
Copy link
Contributor Author

@reneeotten Anything left to be done here?

@reneeotten
Copy link
Contributor

@reneeotten Anything left to be done here?

well the CI fails everywhere - so yes, that needs to be fixed.

@barracuda156
Copy link
Contributor Author

Ok, it suddenly decides it wants extra deps for py39 subport. I will try adding these.

  ERROR Missing dependencies:
  	build
  	importlib-metadata>=4.6
  Command failed:  cd "/opt/local/var/macports/build/_Users_runner_work_macports-ports_macports-ports_ports_python_py-py7zr/py39-py7zr/work/py7zr-0.22.0" && /opt/local/Library/Frameworks/Python.framework/Versions/3.9/bin/python3.9 -m build --no-isolation --wheel --outdir /opt/local/var/macports/build/_Users_runner_work_macports-ports_macports-ports_ports_python_py-py7zr/py39-py7zr/work 
  Error: Failed to build py39-py7zr: command execution failed

@barracuda156
Copy link
Contributor Author

@reneeotten Can you say why this subport fails still?

  Executing:  cd "/opt/local/var/macports/build/_Users_runner_work_macports-ports_macports-ports_ports_python_py-py7zr/py39-py7zr/work/py7zr-0.22.0" && /opt/local/Library/Frameworks/Python.framework/Versions/3.9/bin/python3.9 -m build --no-isolation --wheel --outdir /opt/local/var/macports/build/_Users_runner_work_macports-ports_macports-ports_ports_python_py-py7zr/py39-py7zr/work 
  * Getting build dependencies for wheel...
  /opt/local/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/site-packages/setuptools_scm/git.py:312: UserWarning: git archive did not support describe output
    warnings.warn("git archive did not support describe output")
  /opt/local/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/site-packages/setuptools_scm/git.py:331: UserWarning: unprocessed git archival found (no export subst applied)
    warnings.warn("unprocessed git archival found (no export subst applied)")
  running egg_info
  writing py7zr.egg-info/PKG-INFO
  writing dependency_links to py7zr.egg-info/dependency_links.txt
  writing entry points to py7zr.egg-info/entry_points.txt
  writing requirements to py7zr.egg-info/requires.txt
  writing top-level names to py7zr.egg-info/top_level.txt
  ERROR setuptools_scm._file_finders.git listing git files failed - pretending there aren't any
  reading manifest file 'py7zr.egg-info/SOURCES.txt'
  reading manifest template 'MANIFEST.in'
  no previously-included directories found matching '.github'
  warning: no previously-included files found matching '.gitignore'
  warning: no previously-included files found matching '.readthedocs.yml'
  warning: no previously-included files found matching 'codecov.yml'
  warning: no previously-included files found matching 'azure-pipelines.yml'
  adding license file 'LICENSE'
  writing manifest file 'py7zr.egg-info/SOURCES.txt'
  
  ERROR Missing dependencies:
  	build
  	importlib-metadata>=4.6
  Command failed:  cd "/opt/local/var/macports/build/_Users_runner_work_macports-ports_macports-ports_ports_python_py-py7zr/py39-py7zr/work/py7zr-0.22.0" && /opt/local/Library/Frameworks/Python.framework/Versions/3.9/bin/python3.9 -m build --no-isolation --wheel --outdir /opt/local/var/macports/build/_Users_runner_work_macports-ports_macports-ports_ports_python_py-py7zr/py39-py7zr/work 
  Exit code: 1
  Error: Failed to build py39-py7zr: command execution failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants