Fix dmg installer to not have duplicate images and icons #1545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We added a new step in macvim-dev#1540 to generate the image / icon set for the dmg installer during the dmg build step, but the intermediate files were erroneously placed in the same folder as the one being copied over, causing them to be in the final dmg as well. Just use a scratch folder instead.
ychin
force-pushed
the
fix-dmg-duplicate-images
branch
from
6550dff to
d04d99d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We added a new step in #1540 to generate the image / icon set for the dmg installer during the dmg build step, but the intermediate files were erroneously placed in the same folder as the one being copied over, causing them to be in the final dmg as well. Just use a scratch folder instead.