-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): integrate yamllint and alejandra linters #455
Open
jbcaron
wants to merge
1
commit into
main
Choose a base branch
from
ci/linters
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,10 @@ | ||
--- | ||
blank_issues_enabled: true | ||
|
||
contact_links: | ||
- name: Support & Troubleshooting with Madara Community | ||
url: https://t.me/madara | ||
about: | | ||
about: >- | ||
For general problems with Madara or related technologies, please ask | ||
and questions in our community! We highly encourage everyone also share their understanding by answering questions for others. | ||
questions in our community! We highly encourage everyone to also share | ||
their understanding by answering questions for others. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,8 @@ | ||
--- | ||
version: 2 | ||
updates: | ||
- package-ecosystem: "cargo" | ||
directory: "/" | ||
- package-ecosystem: cargo | ||
directory: / | ||
schedule: | ||
interval: "weekly" # can be `daily` or `monthly` also | ||
interval: weekly # can be `daily` or `monthly` also | ||
open-pull-requests-limit: 10 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,87 +1,84 @@ | ||
--- | ||
- name: "breaking-change" | ||
- name: breaking-change | ||
color: ee0701 | ||
description: "A change that changes the API or breaks backward compatibility for users." | ||
- name: "bump_db" | ||
description: | ||
A change that changes the API or breaks backward compatibility for | ||
users. | ||
- name: bump_db | ||
color: ee0701 | ||
description: "Changes requiring a database version increment." | ||
- name: "bugfix" | ||
description: Changes requiring a database version increment. | ||
- name: bugfix | ||
color: ee0701 | ||
description: | ||
"Inconsistencies or issues which will cause a problem for users or | ||
implementors." | ||
- name: "documentation" | ||
description: Inconsistencies or issues which will cause a problem for users or | ||
implementors. | ||
- name: documentation | ||
color: 0052cc | ||
description: "Solely about the documentation of the project." | ||
- name: "enhancement" | ||
description: Solely about the documentation of the project. | ||
- name: enhancement | ||
color: 1d76db | ||
description: "Enhancement of the code, not introducing new features." | ||
- name: "refactor" | ||
description: Enhancement of the code, not introducing new features. | ||
- name: refactor | ||
color: 1d76db | ||
description: | ||
"Updating the code with simpler, easier to understand or more efficient | ||
syntax or methods, but not introducing new features." | ||
- name: "performance" | ||
Updating the code with simpler, easier to understand or more efficient | ||
syntax or methods, but not introducing new features. | ||
- name: performance | ||
color: 1d76db | ||
description: "Improving performance of the project, not introducing new features." | ||
- name: "new-feature" | ||
description: Improving performance of the project, not introducing new features. | ||
- name: new-feature | ||
color: 0e8a16 | ||
description: "New features or options." | ||
- name: "maintenance" | ||
description: New features or options. | ||
- name: maintenance | ||
color: 2af79e | ||
description: "Generic maintenance tasks." | ||
- name: "ci" | ||
description: Generic maintenance tasks. | ||
- name: ci | ||
color: 1d76db | ||
description: "Work that improves the continuous integration." | ||
- name: "dependencies" | ||
description: Work that improves the continuous integration. | ||
- name: dependencies | ||
color: 1d76db | ||
description: "Change in project dependencies." | ||
|
||
- name: "in-progress" | ||
description: Change in project dependencies. | ||
- name: in-progress | ||
color: fbca04 | ||
description: "Issue is currently being worked on by a developer." | ||
- name: "stale" | ||
description: Issue is currently being worked on by a developer. | ||
- name: stale | ||
color: fef2c0 | ||
description: "No activity for quite some time." | ||
- name: "no-stale" | ||
description: No activity for quite some time. | ||
- name: no-stale | ||
color: fef2c0 | ||
description: "This is exempt from the stale bot." | ||
|
||
- name: "security" | ||
description: This is exempt from the stale bot. | ||
- name: security | ||
color: ee0701 | ||
description: "Addressing a vulnerability or security risk in this project." | ||
- name: "incomplete" | ||
description: Addressing a vulnerability or security risk in this project. | ||
- name: incomplete | ||
color: fef2c0 | ||
description: "Missing information." | ||
- name: "invalid" | ||
description: Missing information. | ||
- name: invalid | ||
color: fef2c0 | ||
description: "This is off-topic, spam, or otherwise doesn't apply to this project." | ||
|
||
- name: "beginner-friendly" | ||
description: This is off-topic, spam, or otherwise doesn't apply to this project. | ||
- name: beginner-friendly | ||
color: 0e8a16 | ||
description: "Good first issue for people wanting to contribute to this project." | ||
- name: "help-wanted" | ||
description: Good first issue for people wanting to contribute to this project. | ||
- name: help-wanted | ||
color: 0e8a16 | ||
description: "We need some extra helping hands or expertise in order to resolve this!" | ||
|
||
- name: "priority-critical" | ||
description: We need some extra helping hands or expertise in order to resolve | ||
this! | ||
- name: priority-critical | ||
color: ee0701 | ||
description: "Must be addressed as soon as possible." | ||
- name: "priority-high" | ||
description: Must be addressed as soon as possible. | ||
- name: priority-high | ||
color: b60205 | ||
description: | ||
"After critical issues are fixed, these should be dealt with before any | ||
further issues." | ||
- name: "priority-medium" | ||
After critical issues are fixed, these should be dealt with before | ||
any further issues. | ||
- name: priority-medium | ||
color: 0e8a16 | ||
description: "This issue may be useful, and needs some attention." | ||
- name: "priority-low" | ||
description: This issue may be useful, and needs some attention. | ||
- name: priority-low | ||
color: e4ea8a | ||
description: "Nice addition, maybe... someday..." | ||
|
||
- name: "major" | ||
description: Nice addition, maybe... someday... | ||
- name: major | ||
color: b60205 | ||
description: "This PR causes a major bump in the version number." | ||
- name: "minor" | ||
description: This PR causes a major bump in the version number. | ||
- name: minor | ||
color: 0e8a16 | ||
description: "This PR causes a minor bump in the version number." | ||
description: This PR causes a minor bump in the version number. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,11 @@ | ||
--- | ||
name: Task - Integration Tests | ||
|
||
on: | ||
"on": | ||
workflow_dispatch: | ||
workflow_call: | ||
secrets: | ||
ETH_FORK_URL: | ||
required: true | ||
|
||
jobs: | ||
coverage: | ||
permissions: | ||
|
@@ -17,28 +16,35 @@ jobs: | |
- name: Setup build deps | ||
run: | | ||
sudo apt-get update | ||
sudo apt-get install -y clang llvm libudev-dev protobuf-compiler gcc g++ build-essential libssl-dev pkg-config curl wget git | ||
sudo apt-get install -y \ | ||
clang \ | ||
llvm \ | ||
libudev-dev \ | ||
protobuf-compiler \ | ||
gcc \ | ||
g++ \ | ||
build-essential \ | ||
libssl-dev \ | ||
pkg-config \ | ||
curl \ | ||
wget \ | ||
git | ||
- uses: dtolnay/rust-toolchain@master | ||
with: | ||
toolchain: 1.81 | ||
|
||
- uses: Swatinem/rust-cache@v2 # use a different cache key as coverae uses custom rustc args | ||
with: | ||
cache-provider: buildjet | ||
key: "coverage" | ||
|
||
key: coverage | ||
- uses: rui314/setup-mold@v1 | ||
- name: Install cargo-llvm-cov | ||
uses: taiki-e/install-action@cargo-llvm-cov | ||
|
||
- uses: software-mansion/setup-scarb@v1 | ||
with: | ||
scarb-version: "2.8.2" | ||
|
||
scarb-version: 2.8.2 | ||
- uses: foundry-rs/foundry-toolchain@v1 | ||
with: | ||
version: nightly | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Suggest keeping line breaks between YAML sections as it follows standard formatting practices and improves readability. |
||
- name: Build and run tests | ||
env: | ||
ETH_FORK_URL: ${{ secrets.ETH_FORK_URL }} | ||
|
@@ -50,12 +56,10 @@ jobs: | |
export COVERAGE_BIN=$(realpath target/debug/madara) | ||
rm -f target/madara-* lcov.info | ||
cargo test --profile dev --workspace -- --test-threads=1 | ||
|
||
- name: Generate coverage info | ||
run: | | ||
source <(cargo llvm-cov show-env --export-prefix) | ||
cargo llvm-cov report --lcov --output-path lcov.info | ||
|
||
- name: Coveralls | ||
uses: coverallsapp/github-action@v2 | ||
with: | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,16 +1,13 @@ | ||
--- | ||
name: Workflow - Daily Cron | ||
|
||
on: | ||
"on": | ||
workflow_dispatch: | ||
schedule: | ||
- cron: "0 0 * * *" | ||
|
||
- cron: 0 0 * * * | ||
jobs: | ||
stale_issues: | ||
name: Stale issues | ||
uses: ./.github/workflows/stale-issues.yml | ||
|
||
security_audit: | ||
name: Security audit | ||
uses: ./.github/workflows/security-audit.yml |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we enforce some kind of spacing between sections for his kind of file?