-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update FlagKit.podspec #79
base: master
Are you sure you want to change the base?
Conversation
Add swift_versions to podspec file to avoid build failures with CocoaPods 1.8.0
Update FlagKit.podspec
Hi, it works fine for me on 1.8.0:
|
On our side it didn't: Ruby version 2.4.1 and fastlane version 2.131.0. Using cocoapods-core 1.8.0
|
Ah, is your project a 100% objc one? |
No, we have to manually set the Swift version for a couple of pods and while we could do this for all pods, some don't necessarily require it - because they already support Swift 5. Some do due to them no longer being maintained or due to version lock so we have to specify the version manually. I got the error message in the terminal o I decided to open a pull request. Maybe there are others that don't want to do the cocoapods post_install shenanigan to set the Swift version and as a thank you for sharing this on GitHub. I looked back in the Swift update commit history since Swift 3.0 and most of the Changes were OS and XCode related - correct me if I'm wrong - so it would probably support out of the box Swift versions from 3.2 upwards. Thanks again, |
CocoaPods say:
|
its a 100% Swift Project and we need this flag. |
Add swift_versions to podspec file to avoid build failures with CocoaPods 1.8.0