Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FlagKit.podspec #79

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update FlagKit.podspec #79

wants to merge 2 commits into from

Conversation

cyupa
Copy link

@cyupa cyupa commented Sep 24, 2019

Add swift_versions to podspec file to avoid build failures with CocoaPods 1.8.0

Add swift_versions to podspec file to avoid build failures with CocoaPods 1.8.0
@blommegard
Copy link
Member

Hi, it works fine for me on 1.8.0:

➜  pod install          
Analyzing dependencies
Downloading dependencies
Generating Pods project
Integrating client project
Pod installation complete! There is 1 dependency from the Podfile and 1 total pod installed.

@cyupa
Copy link
Author

cyupa commented Sep 24, 2019

On our side it didn't:

Ruby version 2.4.1 and fastlane version 2.131.0.

Using cocoapods-core 1.8.0
Using cocoapods-deintegrate 1.0.4
Using cocoapods-downloader 1.2.2
Using cocoapods-plugins 1.0.0
Using cocoapods-search 1.0.0
Using cocoapods-stats 1.1.0
Using cocoapods-trunk 1.4.0
Using cocoapods-try 1.1.0
Using cocoapods 1.8.0

[!] Unable to determine Swift version for the following pods:

- `FlagKit-library` does not specify a Swift version and none of the targets (`Pods`) integrating it have the `SWIFT_VERSION` attribute set. Please contact the author or set the `SWIFT_VERSION` attribute in at least one of the targets that integrate this pod.

@blommegard
Copy link
Member

Ah, is your project a 100% objc one?

@cyupa
Copy link
Author

cyupa commented Sep 24, 2019

No, we have to manually set the Swift version for a couple of pods and while we could do this for all pods, some don't necessarily require it - because they already support Swift 5. Some do due to them no longer being maintained or due to version lock so we have to specify the version manually.

I got the error message in the terminal o I decided to open a pull request. Maybe there are others that don't want to do the cocoapods post_install shenanigan to set the Swift version and as a thank you for sharing this on GitHub.

I looked back in the Swift update commit history since Swift 3.0 and most of the Changes were OS and XCode related - correct me if I'm wrong - so it would probably support out of the box Swift versions from 3.2 upwards.

Thanks again,
Ciprian

@StefaniOSApps
Copy link

CocoaPods say:
[!] Unable to determine Swift version for the following pods:

  • FlagKit does not specify a Swift version and none of the targets (XXX XXX and XXX) integrating it have the SWIFT_VERSION attribute set. Please contact the author or set the SWIFT_VERSION attribute in at least one of the targets that integrate this pod.

@StefaniOSApps
Copy link

its a 100% Swift Project and we need this flag.

@StefaniOSApps
Copy link

@blommegard @cyupa

@StefaniOSApps
Copy link

@wopian @gellermark @yageek @antontingstrom @hannseman @ReadmeCritic @edwardjewson @MosheBerman

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants