[hotfix] Slise ads return empty cache-controlled data

madfish-solutions · Feb 20, 2024 · a16beb0 · a16beb0
1 parent ee47e17
commit a16beb0
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 9 deletions.
diff --git a/src/routers/slise-ad-rules/providers.ts b/src/routers/slise-ad-rules/providers.ts
@@ -6,7 +6,7 @@ import {
   getAllSliseAdProvidersBySites,
   getSelectorsByProviderId,
   getSliseAdProvidersByDomain,
-  getSliseAdProvidersForAllSites,
+  // getSliseAdProvidersForAllSites,
   removeProviders,
   removeSliseAdProvidersBySites,
   removeSliseAdProvidersForAllSites,
@@ -157,9 +157,10 @@ sliseAdProvidersRouter
   .route('/all-sites')
   .get(
     withExceptionHandler(async (_req, res) => {
-      const providers = await getSliseAdProvidersForAllSites();
+      // const providers = await getSliseAdProvidersForAllSites();
 
-      res.status(200).send(providers);
+      // res.status(200).send(providers);
+      res.status(200).header('Cache-Control', 'public, max-age=300').send([]);
     })
   )
   .post(

diff --git a/src/utils/express-helpers.ts b/src/utils/express-helpers.ts
@@ -44,7 +44,7 @@ export const withExceptionHandler =
     }
   };
 
-export const addObjectStorageMethodsToRouter = <V>(
+export const addObjectStorageMethodsToRouter = <V extends any[]>(
   router: Router,
   path: string,
   methods: ObjectStorageMethods<V>,
@@ -56,21 +56,23 @@ export const addObjectStorageMethodsToRouter = <V>(
   router.get(
     path === '/' ? `/:${keyName}` : `${path}/:${keyName}`,
     withExceptionHandler(async (req, res) => {
-      const { [keyName]: key } = req.params;
+      // const { [keyName]: key } = req.params;
 
-      const value = await methods.getByKey(key);
+      // const value = await methods.getByKey(key);
+      const value = [];
 
-      res.status(200).send(value);
+      res.status(200).header('Cache-Control', 'public, max-age=300').send(value);
     })
   );
 
   router
     .route(path)
     .get(
       withExceptionHandler(async (_req, res) => {
-        const values = await methods.getAllValues();
+        // const values = await methods.getAllValues();
+        const values = {};
 
-        res.status(200).send(values);
+        res.status(200).header('Cache-Control', 'public, max-age=300').send(values);
       })
     )
     .post(