TW-1282 Use /prices 3route API entry #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-tsx
reviewed
Feb 2, 2024
Co-authored-by: Alex <[email protected]>
alex-tsx
approved these changes
Feb 2, 2024
alex-tsx
approved these changes
Feb 2, 2024
| @@ -40,14 +40,14 @@ const getTokensExchangeRates = async (): Promise<TokenExchangeRateEntry[]> => { | |||
| } | |||
|
|
|||
| const exchangeRatesWithHoles = await Promise.all( | |||
| tokens | |||
| tokens! | |||
There was a problem hiding this comment.
We could define someProvider.getState() so that its return type is
Promise<
{ data: undefined; error: unknown }
| { data: T; error: undefined }
>+ As I see it, these providers are only a memoization mechanisms, that can be replaced with memoizee.
lendihop
approved these changes
Feb 2, 2024
tttt24
approved these changes
Feb 6, 2024
lourenc
added a commit
that referenced
this pull request
Feb 20, 2024
TW-1282: Use /prices 3route API entry (#143)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.