Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TW-1096: Add new Alice-Bob exchange pairs #1002

Merged
merged 10 commits into from
Oct 11, 2023
Merged

TW-1096: Add new Alice-Bob exchange pairs #1002

merged 10 commits into from
Oct 11, 2023

Conversation

lendihop
Copy link
Contributor

@lendihop lendihop temporarily deployed to development September 29, 2023 19:03 — with GitHub Actions Inactive
@lendihop lendihop temporarily deployed to development September 29, 2023 19:09 — with GitHub Actions Inactive
@lendihop lendihop temporarily deployed to development September 29, 2023 19:36 — with GitHub Actions Inactive
keshan3262
keshan3262 previously approved these changes Oct 1, 2023
View reviewed changes
alex-tsx
alex-tsx previously approved these changes Oct 2, 2023
View reviewed changes
Copy link
Collaborator

@alex-tsx alex-tsx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, remove currency-codes package or use it

src/app/store/buy-with-credit-card/utils.ts Outdated Show resolved Hide resolved
src/app/hooks/AliceBob/use-output-currencies.ts Outdated Show resolved Hide resolved
@lendihop lendihop dismissed stale reviews from alex-tsx and keshan3262 via d305ab3 October 2, 2023 10:07
@lendihop lendihop temporarily deployed to development October 2, 2023 10:07 — with GitHub Actions Inactive
keshan3262
keshan3262 previously approved these changes Oct 2, 2023
View reviewed changes
alex-tsx
alex-tsx previously approved these changes Oct 2, 2023
View reviewed changes
Copy link
Collaborator

@alex-tsx alex-tsx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ!

@IrynaKhyzhynska IrynaKhyzhynska temporarily deployed to development October 2, 2023 12:24 — with GitHub Actions Inactive
@lendihop lendihop dismissed stale reviews from alex-tsx and keshan3262 via 75a311a October 3, 2023 09:12
@lendihop lendihop temporarily deployed to development October 3, 2023 09:12 — with GitHub Actions Inactive
@lendihop lendihop temporarily deployed to development October 3, 2023 10:42 — with GitHub Actions Inactive
@IrynaKhyzhynska IrynaKhyzhynska temporarily deployed to development October 3, 2023 14:39 — with GitHub Actions Inactive
tttt24
tttt24 approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@tttt24 tttt24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chrome

IrynaKhyzhynska
IrynaKhyzhynska approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@IrynaKhyzhynska IrynaKhyzhynska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

firefox done

@lourenc lourenc merged commit 866c4ed into development Oct 11, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tttt24 tttt24 tttt24 approved these changes

@alex-tsx alex-tsx alex-tsx approved these changes

@IrynaKhyzhynska IrynaKhyzhynska IrynaKhyzhynska approved these changes

@keshan3262 keshan3262 keshan3262 approved these changes

Assignees
No one assigned
Labels
qa approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lendihop @keshan3262 @IrynaKhyzhynska @alex-tsx @tttt24 @lourenc